Bug 1386357 - remove usage of sdk/timers in DevTools;r=ochameau draft
authorJulian Descottes <jdescottes@mozilla.com>
Wed, 02 Aug 2017 12:53:20 +0200
changeset 620433 0c2636114a2a44017b0f8af749025d7465cfb906
parent 620349 f47f8b5a9b99692c6582763eedaefadf0af997de
child 620471 c1eeedc71e3c01041364f6c8f6d7e97dafe008e2
child 620501 09e6fd7b50b7319b18cd51ddcbc919de23c5ce49
push id72033
push userjdescottes@mozilla.com
push dateThu, 03 Aug 2017 12:38:17 +0000
reviewersochameau
bugs1386357
milestone56.0a1
Bug 1386357 - remove usage of sdk/timers in DevTools;r=ochameau MozReview-Commit-ID: 8rC2peDRBJW
devtools/client/canvasdebugger/test/head.js
devtools/client/framework/test/browser_browser_toolbox_debugger.js
devtools/server/tests/unit/test_promises_object_timetosettle-02.js
devtools/shared/discovery/tests/unit/test_discovery.js
--- a/devtools/client/canvasdebugger/test/head.js
+++ b/devtools/client/canvasdebugger/test/head.js
@@ -9,17 +9,16 @@ var { require } = Cu.import("resource://
 
 var Services = require("Services");
 var promise = require("promise");
 var { gDevTools } = require("devtools/client/framework/devtools");
 var { DebuggerClient } = require("devtools/shared/client/main");
 var { DebuggerServer } = require("devtools/server/main");
 var { CallWatcherFront } = require("devtools/shared/fronts/call-watcher");
 var { CanvasFront } = require("devtools/shared/fronts/canvas");
-var { setTimeout } = require("sdk/timers");
 var DevToolsUtils = require("devtools/shared/DevToolsUtils");
 var flags = require("devtools/shared/flags");
 var { TargetFactory } = require("devtools/client/framework/target");
 var { Toolbox } = require("devtools/client/framework/toolbox");
 var { isWebGLSupported } = require("devtools/client/shared/webgl-utils");
 var mm = null;
 
 const FRAME_SCRIPT_UTILS_URL = "chrome://devtools/content/shared/frame-script-utils.js";
--- a/devtools/client/framework/test/browser_browser_toolbox_debugger.js
+++ b/devtools/client/framework/test/browser_browser_toolbox_debugger.js
@@ -5,17 +5,16 @@
 // This test asserts that the new debugger works from the browser toolbox process
 // Its pass a big piece of Javascript string to the browser toolbox process via
 // MOZ_TOOLBOX_TEST_SCRIPT env variable. It does that as test resources fetched from
 // chrome://mochitests/ package isn't available from browser toolbox process.
 
 // On debug test runner, it takes about 50s to run the test.
 requestLongerTimeout(4);
 
-const { setInterval, clearInterval } = require("sdk/timers");
 const { fetch } = require("devtools/shared/DevToolsUtils");
 
 const debuggerHeadURL = CHROME_URL_ROOT + "../../debugger/new/test/mochitest/head.js";
 const testScriptURL = CHROME_URL_ROOT + "test_browser_toolbox_debugger.js";
 
 add_task(function* runTest() {
   yield new Promise(done => {
     let options = {"set": [
--- a/devtools/server/tests/unit/test_promises_object_timetosettle-02.js
+++ b/devtools/server/tests/unit/test_promises_object_timetosettle-02.js
@@ -4,17 +4,17 @@
 
 /**
  * Test that we get the expected settlement time for promise time to settle.
  */
 
 "use strict";
 
 const { PromisesFront } = require("devtools/shared/fronts/promises");
-const { setTimeout } = require("sdk/timers");
+const { setTimeout } = Cu.import("resource://gre/modules/Timer.jsm", {});
 
 var events = require("sdk/event/core");
 
 add_task(function* () {
   let client = yield startTestDebuggerServer("test-promises-timetosettle");
   let chromeActors = yield getChromeActors(client);
   yield attachTab(client, chromeActors);
 
--- a/devtools/shared/discovery/tests/unit/test_discovery.js
+++ b/devtools/shared/discovery/tests/unit/test_discovery.js
@@ -7,17 +7,17 @@
 var Cu = Components.utils;
 
 const { require } =
   Cu.import("resource://devtools/shared/Loader.jsm", {});
 const Services = require("Services");
 const defer = require("devtools/shared/defer");
 const EventEmitter = require("devtools/shared/event-emitter");
 const discovery = require("devtools/shared/discovery/discovery");
-const { setTimeout, clearTimeout } = require("sdk/timers");
+const { setTimeout, clearTimeout } = Cu.import("resource://gre/modules/Timer.jsm", {});
 
 Services.prefs.setBoolPref("devtools.discovery.log", true);
 
 do_register_cleanup(() => {
   Services.prefs.clearUserPref("devtools.discovery.log");
 });
 
 function log(msg) {