Bug 1381876 - Make client.Session#maximize a method. r?automatedtester draft
authorAndreas Tolfsen <ato@sny.no>
Tue, 01 Aug 2017 18:22:52 +0100
changeset 641127 b45eafe0b96700ef5011b645fa761113a9d5ca9e
parent 641126 cc266c94458f0752ee72dc0071f8bd9cc296e82a
child 641128 7eeb43e2f45d79b64443d9a817d7ebdf757760cc
push id72441
push userbmo:ato@sny.no
push dateSat, 05 Aug 2017 16:50:51 +0000
reviewersautomatedtester
bugs1381876
milestone57.0a1
Bug 1381876 - Make client.Session#maximize a method. r?automatedtester The Maximize Window command is a POST endpoint and should consequently be a method, not a property. MozReview-Commit-ID: DJfKdhMIX75
testing/web-platform/tests/tools/webdriver/webdriver/client.py
--- a/testing/web-platform/tests/tools/webdriver/webdriver/client.py
+++ b/testing/web-platform/tests/tools/webdriver/webdriver/client.py
@@ -258,17 +258,16 @@ class Window(object):
 
     @position.setter
     @command
     def position(self, data):
         data = x, y
         body = {"x": x, "y": y}
         self.session.send_session_command("POST", "window/rect", body)
 
-    @property
     @command
     def maximize(self):
         return self.session.send_session_command("POST", "window/maximize")
 
 
 class Find(object):
     def __init__(self, session):
         self.session = session