Bug 1381876 - Compare window rect, not window size. r?automatedtester
The dictionary from Marionette#window_size is a subset of what is returned
from Marionette#window_rect, causing the self.assertEqual to complain
that they are not equal. We want to compare the same types.
MozReview-Commit-ID: L4XTlgtUYKW
--- a/testing/marionette/harness/marionette_harness/tests/unit/test_window_maximize.py
+++ b/testing/marionette/harness/marionette_harness/tests/unit/test_window_maximize.py
@@ -55,21 +55,21 @@ class TestWindowMaximize(MarionetteTestC
self.assertIn("x", rect)
self.assertIn("y", rect)
self.assertIsInstance(rect["width"], int)
self.assertIsInstance(rect["height"], int)
self.assertIsInstance(rect["x"], int)
self.assertIsInstance(rect["y"], int)
def test_maximize(self):
- rect = self.marionette.maximize_window()
- self.assert_window_rect(rect)
- size = self.marionette.window_size
- self.assertEqual(size, rect)
- self.assert_window_maximized(size)
+ maximize_resp = self.marionette.maximize_window()
+ self.assert_window_rect(maximize_resp)
+ window_rect_resp = self.marionette.window_rect
+ self.assertEqual(maximize_resp, window_rect_resp)
+ self.assert_window_maximized(maximize_resp)
def test_maximize_twice_restores(self):
maximized = self.marionette.maximize_window()
self.assert_window_maximized(maximized)
restored = self.marionette.maximize_window()
self.assert_window_restored(restored)
