Bug 1383879 - Always position the nav-bar when the TabsToolbar is not collapsed since the positioning of the animations is dependent on the container having position:relative. r?gijs draft
authorJared Wein <jwein@mozilla.com>
Mon, 31 Jul 2017 13:26:32 -0400
changeset 619011 2e3633b7bda1adf5cc8cf8c3fb487a6675849fb4
parent 618757 44121dbcac6a9d3ff18ed087a09b3205e5a04db1
child 640264 81d49c86ac50ac1cdfccaf4858cbf773c678a293
push id71539
push userbmo:jaws@mozilla.com
push dateTue, 01 Aug 2017 11:54:23 +0000
reviewersgijs
bugs1383879
milestone56.0a1
Bug 1383879 - Always position the nav-bar when the TabsToolbar is not collapsed since the positioning of the animations is dependent on the container having position:relative. r?gijs We don't need to position the nav-bar if the TabsToolbar is collapsed since the buttons that we would animate (such as stop/reload) are display:none when the TabsToolbar is hidden. MozReview-Commit-ID: EUkHz3erxM
browser/themes/osx/browser.css
--- a/browser/themes/osx/browser.css
+++ b/browser/themes/osx/browser.css
@@ -268,16 +268,22 @@ toolbar:-moz-lwtheme {
     z-index: 1;
   }
 
   #main-window[tabsintitlebar] #TabsToolbar:not([collapsed="true"]) + #nav-bar:-moz-window-inactive:not(:-moz-lwtheme) {
     border-top-color: hsla(0,0%,0%,.05);
   }
 }
 
+#TabsToolbar:not([collapsed="true"]) + #nav-bar {
+  /* The toolbar buttons that animate are only visible when the #TabsToolbar is not collapsed.
+     The animations use position:absolute and require a positioned #nav-bar. */
+  position: relative;
+}
+
 #PersonalToolbar {
   padding: 0 4px 4px;
 }
 
 #PersonalToolbar:not([collapsed=true]) {
   /* 4px padding ^  plus 19px personal-bookmarks (see below) */
   min-height: 23px;
 }