Bug 1385407 - Add an extra selector for the urlbar-icon within the star-button-box now that the urlbar-icon for the bookmark star isn't a direct child of urlbar-icons. r?gijs
This change in markup was necessary to implement
bug 1352063. I have audited all other CSS to make sure other selectors looking for this icon still apply. This was the only one found that needed to be updated.
The change to browser_startup_images.js is not actually a new image that is loaded at startup, but a revert of 767224f031ac (
bug 1352063) which removed that section (the test failing due to that section no longer applying should have called out what was necessary to fix this bug).
MozReview-Commit-ID: 6O1iUUjJ0dh
--- a/browser/base/content/browser.css
+++ b/browser/base/content/browser.css
@@ -686,16 +686,17 @@ html|input.urlbar-input[textoverflow]:no
}
#DateTimePickerPanel[active="true"] {
-moz-binding: url("chrome://global/content/bindings/datetimepopup.xml#datetime-popup");
}
#urlbar[pageproxystate="invalid"] > #urlbar-icons > .urlbar-icon,
%ifdef MOZ_PHOTON_THEME
+#urlbar[pageproxystate="invalid"] > #urlbar-icons > #star-button-box > .urlbar-icon,
.urlbar-go-button[pageproxystate="valid"],
.urlbar-go-button:not([parentfocused="true"]),
%else
#urlbar[pageproxystate="invalid"][focused="true"] > #urlbar-go-button ~ toolbarbutton,
#urlbar[pageproxystate="valid"] > #urlbar-go-button,
#urlbar:not([focused="true"]) > #urlbar-go-button,
%endif
#urlbar[pageproxystate="invalid"] > #identity-box > #blocked-permissions-container,
--- a/browser/base/content/test/performance/browser_startup_images.js
+++ b/browser/base/content/test/performance/browser_startup_images.js
@@ -26,16 +26,21 @@
const whitelist = [
// Photon-only entries
{
file: "chrome://browser/skin/stop.svg",
platforms: ["linux", "win", "macosx"],
photon: true,
},
{
+ file: "chrome://browser/skin/bookmark-hollow.svg",
+ platforms: ["linux", "win", "macosx"],
+ photon: true,
+ },
+ {
file: "chrome://browser/skin/page-action.svg",
platforms: ["linux", "win", "macosx"],
photon: true,
},
// Non-Photon-only entries
{
file: "chrome://browser/skin/toolbarbutton-dropdown-arrow.png",