Bug 1094812 - Remove now unused PlacesTransactions.RemoveBookmarksForUrls. r?mak
MozReview-Commit-ID: HFAQCIbbT5E
--- a/toolkit/components/places/PlacesTransactions.jsm
+++ b/toolkit/components/places/PlacesTransactions.jsm
@@ -1472,35 +1472,16 @@ PT.Remove.prototype = {
await createItemsFromBookmarksTree(info, true);
}
};
this.redo = removeThem;
}
};
/**
- * Transactions for removing all bookmarks for one or more urls.
- *
- * Required Input Properties: urls.
- */
-PT.RemoveBookmarksForUrls = DefineTransaction(["urls"]);
-PT.RemoveBookmarksForUrls.prototype = {
- async execute({ urls }) {
- let guids = [];
- for (let url of urls) {
- await PlacesUtils.bookmarks.fetch({ url }, b => guids.push(b.guid));
- }
- let removeTxn = TransactionsHistory.getRawTransaction(PT.Remove(guids));
- await removeTxn.execute();
- this.undo = removeTxn.undo.bind(removeTxn);
- this.redo = removeTxn.redo.bind(removeTxn);
- }
-};
-
-/**
* Transaction for tagging urls.
*
* Required Input Properties: urls, tags.
*/
PT.Tag = DefineTransaction(["urls", "tags"]);
PT.Tag.prototype = {
async execute({ urls, tags }) {
let onUndo = [], onRedo = [];
--- a/toolkit/components/places/tests/unit/test_async_transactions.js
+++ b/toolkit/components/places/tests/unit/test_async_transactions.js
@@ -1684,41 +1684,8 @@ add_task(async function test_remove_mult
// Redo remove.
await PT.redo();
await ensureNonExistent(...guids);
// Cleanup
await PT.clearTransactionsHistory();
observer.reset();
});
-
-add_task(async function test_remove_bookmarks_for_urls() {
- let urls = [new URL("http://test.url.1"), new URL("http://test.url.2")];
- let guids = [];
- await PT.batch(async function() {
- for (let url of urls) {
- for (let title of ["test title a", "test title b"]) {
- let txn = PT.NewBookmark({ url, title, parentGuid: rootGuid });
- guids.push(await txn.transact());
- }
- }
- });
-
- let originalInfos = [];
- for (let guid of guids) {
- originalInfos.push(await PlacesUtils.promiseBookmarksTree(guid));
- }
-
- await PT.RemoveBookmarksForUrls(urls).transact();
- await ensureNonExistent(...guids);
- await PT.undo();
- await ensureBookmarksTreeRestoredCorrectly(...originalInfos);
- await PT.redo();
- await ensureNonExistent(...guids);
- await PT.undo();
- await ensureBookmarksTreeRestoredCorrectly(...originalInfos);
-
- // Cleanup.
- await PT.redo();
- await ensureNonExistent(...guids);
- await PT.clearTransactionsHistory();
- observer.reset();
-});