Bug 1385910 - In the error message, also ask to upload the pre-elfhacked library r?froydnj draft
authorSylvestre Ledru <sledru@mozilla.com>
Mon, 31 Jul 2017 16:35:03 +0200
changeset 618920 b02162cfcd15ac4408bb9fc09d4b88ffd00eaf8c
parent 618383 26516ba270816a6cc90f5c42a9b66701369a551f
child 640225 2ae5e6ea9ddc20011c1ebd3e0f3e3d2d4702a975
push id71499
push userbmo:sledru@mozilla.com
push dateTue, 01 Aug 2017 08:17:40 +0000
reviewersfroydnj
bugs1385910
milestone56.0a1
Bug 1385910 - In the error message, also ask to upload the pre-elfhacked library r?froydnj MozReview-Commit-ID: A7ADGyQunjN
build/unix/elfhack/Makefile.in
--- a/build/unix/elfhack/Makefile.in
+++ b/build/unix/elfhack/Makefile.in
@@ -6,18 +6,19 @@
 OS_CXXFLAGS := $(filter-out -fno-exceptions,$(OS_CXXFLAGS)) -fexceptions
 
 include $(topsrcdir)/config/rules.mk
 
 test-array$(DLL_SUFFIX) test-ctors$(DLL_SUFFIX): %$(DLL_SUFFIX): %.$(OBJ_SUFFIX) elfhack
 	$(MKSHLIB) $(LDFLAGS) $< -nostartfiles
 	@echo ===
 	@echo === If you get failures below, please file a bug describing the error
-	@echo === and your environment \(compiler and linker versions\), and use
-	@echo === --disable-elf-hack until this is fixed.
+	@echo === and your environment \(compiler and linker versions\), and
+	@echo === provide the pre-elfhacked library as an attachment.
+	@echo === Use --disable-elf-hack until this is fixed.
 	@echo ===
 	# Fail if the library doesn't have $(DT_TYPE) .dynamic info
 	$(TOOLCHAIN_PREFIX)readelf -d $@ | grep '($(DT_TYPE))'
 	@rm -f $@.bak
 	$(CURDIR)/elfhack -b -f $@
 	# Fail if the backup file doesn't exist
 	[ -f '$@.bak' ]
 	# Fail if the new library doesn't contain less relocations