Bug 1385703 - Add parentheses to fix a warning (& has lower precedence than ==) r?glandium draft
authorSylvestre Ledru <sledru@mozilla.com>
Sun, 30 Jul 2017 15:32:14 +0200
changeset 618187 200c687793fbc41eb273abfae489ef23e61d3bac
parent 618186 6d1b50a370b4adffbb1ee73b9f51707c90d6a2b1
child 639976 26abe84e70b2f0413e2f219f9c880a7ed9f204c9
push id71229
push userbmo:sledru@mozilla.com
push dateSun, 30 Jul 2017 13:32:54 +0000
reviewersglandium
bugs1385703
milestone56.0a1
Bug 1385703 - Add parentheses to fix a warning (& has lower precedence than ==) r?glandium MozReview-Commit-ID: GdhGFVHqIeb
build/unix/elfhack/elfhack.cpp
--- a/build/unix/elfhack/elfhack.cpp
+++ b/build/unix/elfhack/elfhack.cpp
@@ -725,17 +725,17 @@ int do_relocation_section(Elf *elf, unsi
         Rel_Type &rel = new_rels.back();
         memset(&rel, 0, sizeof(rel));
         rel.r_info = ELF32_R_INFO(std::distance(symtab->syms.begin(), std::vector<Elf_SymValue>::iterator(mprotect)), rel_type2);
 
         // Find the beginning of the bss section, and use an aligned location in there
         // for the relocation.
         for (ElfSegment *segment = elf->getSegmentByType(PT_LOAD); segment;
              segment = elf->getSegmentByType(PT_LOAD, segment)) {
-            if (segment->getFlags() & PF_W == 0)
+            if (segment->getFlags() & (PF_W == 0))
                 continue;
             size_t ptr_size = Elf_Addr::size(elf->getClass());
             size_t aligned_mem_end = (segment->getAddr() + segment->getMemSize() + ptr_size - 1) & ~(ptr_size - 1);
             size_t aligned_file_end = (segment->getAddr() + segment->getFileSize() + ptr_size - 1) & ~(ptr_size - 1);
             if (aligned_mem_end - aligned_file_end >= Elf_Addr::size(elf->getClass())) {
                 mprotect_cb = rel.r_offset = aligned_file_end;
                 break;
             }