Bug 1094357 - Implement underglow effect on dark favicons to make them visible on Photon style tabs. r= draft
authorNihanth Subramanya <nhnt11@gmail.com>
Sun, 30 Jul 2017 07:57:39 +0530
changeset 619389 9f523ec1cc9048ad472878674bd4a82d4a77d41f
parent 619309 a3e675a3b10a0ea289c301bedc31866f3daf7875
child 640383 190d9d2386662d8811282ed4ab927161aa4d0c9d
push id71664
push usernhnt11@gmail.com
push dateTue, 01 Aug 2017 23:30:18 +0000
bugs1094357
milestone56.0a1
Bug 1094357 - Implement underglow effect on dark favicons to make them visible on Photon style tabs. r= MozReview-Commit-ID: E7VrEfRsZCd
browser/base/content/tabbrowser.xml
browser/themes/shared/tabs.inc.css
--- a/browser/base/content/tabbrowser.xml
+++ b/browser/base/content/tabbrowser.xml
@@ -7452,17 +7452,17 @@
                     class="tab-background-end"/>
         </xul:hbox>
         <xul:hbox xbl:inherits="pinned,selected=visuallyselected,titlechanged,attention"
                   class="tab-content" align="center">
           <xul:image xbl:inherits="fadein,pinned,busy,progress,selected=visuallyselected"
                      class="tab-throbber"
                      role="presentation"
                      layer="true" />
-          <xul:image xbl:inherits="src=image,loadingprincipal=iconLoadingPrincipal,fadein,pinned,selected=visuallyselected,busy,crashed,sharing"
+          <xul:image xbl:inherits="src=image,loadingprincipal=iconLoadingPrincipal,fadein,pinned,selected=visuallyselected,busy,crashed,sharing,darkicon"
                      anonid="tab-icon-image"
                      class="tab-icon-image"
                      validate="never"
                      role="presentation"/>
           <xul:image xbl:inherits="sharing,selected=visuallyselected"
                      anonid="sharing-icon"
                      class="tab-sharing-icon-overlay"
                      role="presentation"/>
--- a/browser/themes/shared/tabs.inc.css
+++ b/browser/themes/shared/tabs.inc.css
@@ -89,16 +89,20 @@
   list-style-image: url("chrome://mozapps/skin/places/defaultFavicon.svg");
 }
 
 .tab-icon-image[sharing]:not([selected]),
 .tab-sharing-icon-overlay {
   animation: 3s linear tab-sharing-icon-pulse infinite;
 }
 
+.tab-icon-image[darkicon] {
+  filter: drop-shadow(0 0 3px rgba(255, 255, 255, 0.75));
+}
+
 /* This should remain identical to identity-box-sharing-icon-pulse in identity-block.inc.css */
 @keyframes tab-sharing-icon-pulse {
   0%, 16.66%, 83.33%, 100% {
     opacity: 0;
   }
   33.33%, 66.66% {
     opacity: 1;
   }