Bug 1385529 - Remove Gecko_GetMediaFeatures and access nsMediaFeatures::features directly. r?emilio draft
authorXidorn Quan <me@upsuper.org>
Sat, 29 Jul 2017 15:21:36 +1000
changeset 618021 118df5d21ba1930a7fa52608dcd4c4ec3e0d43d5
parent 617991 7092c550cb3830ac7757b914dd3370edd81ead6e
child 639942 7933594c1e082dfcf721cbd0ae301851f2eb345f
push id71192
push userxquan@mozilla.com
push dateSat, 29 Jul 2017 10:23:22 +0000
reviewersemilio
bugs1385529
milestone56.0a1
Bug 1385529 - Remove Gecko_GetMediaFeatures and access nsMediaFeatures::features directly. r?emilio MozReview-Commit-ID: IbTikEgabXA
layout/style/ServoBindings.cpp
layout/style/ServoBindings.h
layout/style/ServoBindings.toml
--- a/layout/style/ServoBindings.cpp
+++ b/layout/style/ServoBindings.cpp
@@ -2530,22 +2530,16 @@ Gecko_LoadStyleSheet(css::Loader* aLoade
     return emptySheet.forget().take();
   }
 
   RefPtr<ServoStyleSheet> sheet =
     static_cast<ServoStyleSheet*>(aParent->GetFirstChild());
   return sheet.forget().take();
 }
 
-const nsMediaFeature*
-Gecko_GetMediaFeatures()
-{
-  return nsMediaFeatures::features;
-}
-
 nsCSSKeyword
 Gecko_LookupCSSKeyword(const uint8_t* aString, uint32_t aLength)
 {
   MOZ_ASSERT(NS_IsMainThread());
 
   nsDependentCSubstring keyword(reinterpret_cast<const char*>(aString), aLength);
   return nsCSSKeywords::LookupKeyword(keyword);
 }
--- a/layout/style/ServoBindings.h
+++ b/layout/style/ServoBindings.h
@@ -601,17 +601,16 @@ void ShutdownServo();
 void AssertIsMainThreadOrServoLangFontPrefsCacheLocked();
 
 mozilla::ServoStyleSheet* Gecko_StyleSheet_Clone(
     const mozilla::ServoStyleSheet* aSheet,
     const mozilla::ServoStyleSheet* aNewParentSheet);
 void Gecko_StyleSheet_AddRef(const mozilla::ServoStyleSheet* aSheet);
 void Gecko_StyleSheet_Release(const mozilla::ServoStyleSheet* aSheet);
 
-const nsMediaFeature* Gecko_GetMediaFeatures();
 nsCSSKeyword Gecko_LookupCSSKeyword(const uint8_t* string, uint32_t len);
 const char* Gecko_CSSKeywordString(nsCSSKeyword keyword, uint32_t* len);
 
 // Font face rule
 // Creates and returns a new (already-addrefed) nsCSSFontFaceRule object.
 nsCSSFontFaceRule* Gecko_CSSFontFaceRule_Create(uint32_t line, uint32_t column);
 nsCSSFontFaceRule* Gecko_CSSFontFaceRule_Clone(const nsCSSFontFaceRule* rule);
 void Gecko_CSSFontFaceRule_GetCssText(const nsCSSFontFaceRule* rule, nsAString* result);
--- a/layout/style/ServoBindings.toml
+++ b/layout/style/ServoBindings.toml
@@ -418,17 +418,16 @@ structs-types = [
     "nsCSSValue",
     "nsCSSValueSharedList",
     "nsChangeHint",
     "nsCursorImage",
     "nsFont",
     "nsIAtom",
     "nsIURI",
     "nsCompatibility",
-    "nsMediaFeature",
     "nsRestyleHint",
     "nsStyleBackground",
     "nsStyleBorder",
     "nsStyleColor",
     "nsStyleColumn",
     "nsStyleContent",
     "nsStyleContentData",
     "nsStyleContentData_CounterFunction",