Bug 1384964 - Fix pageAction.show/hide/getPopup/setPopup on Android for tabId 0.
MozReview-Commit-ID: FVcbQkiTGqe
--- a/mobile/android/components/extensions/ext-pageAction.js
+++ b/mobile/android/components/extensions/ext-pageAction.js
@@ -232,32 +232,32 @@ this.pageAction = class extends Extensio
};
pageActionMap.get(extension).on("click", listener);
return () => {
pageActionMap.get(extension).off("click", listener);
};
}).api(),
show(tabId) {
- let tab = tabId ? tabTracker.getTab(tabId) : null;
+ let tab = tabTracker.getTab(tabId);
return pageActionMap.get(extension).setProperty(tab, "show", true);
},
hide(tabId) {
- let tab = tabId ? tabTracker.getTab(tabId) : null;
+ let tab = tabTracker.getTab(tabId);
pageActionMap.get(extension).setProperty(tab, "show", false);
},
setPopup(details) {
- let tab = details.tabId ? tabTracker.getTab(details.tabId) : null;
+ let tab = tabTracker.getTab(details.tabId);
let url = details.popup && context.uri.resolve(details.popup);
pageActionMap.get(extension).setProperty(tab, "popup", url);
},
getPopup(details) {
- let tab = details.tabId ? tabTracker.getTab(details.tabId) : null;
+ let tab = tabTracker.getTab(details.tabId);
let popup = pageActionMap.get(extension).getProperty(tab, "popup");
return Promise.resolve(popup);
},
},
};
}
};