Bug 1384402 - Fix broken about:preferences link after reorg v2 r?jaws draft
authorRicky Chien <ricky060709@gmail.com>
Thu, 27 Jul 2017 11:30:05 +0800
changeset 617143 683a5bdbbef54f64d6774c8cbba458948a975453
parent 617134 a4afa89bfdd10a903cfa9aa5a5bd1624dc85548c
child 639715 c1ff71d700dae391e12ea0cb4df01184e82f1f99
push id70941
push userbmo:rchien@mozilla.com
push dateFri, 28 Jul 2017 00:25:43 +0000
reviewersjaws
bugs1384402
milestone56.0a1
Bug 1384402 - Fix broken about:preferences link after reorg v2 r?jaws MozReview-Commit-ID: LnQsKHhrDWI
browser/base/content/browser-media.js
browser/components/newtab/NewTabSearchProvider.jsm
browser/components/preferences/in-content-new/main.xul
browser/modules/ContentSearch.jsm
--- a/browser/base/content/browser-media.js
+++ b/browser/base/content/browser-media.js
@@ -167,17 +167,17 @@ var gEMEHandler = {
 
     let mainAction = {
       label: gNavigatorBundle.getString(btnLabelId),
       accessKey: gNavigatorBundle.getString(btnAccessKeyId),
       callback() {
         if (Services.prefs.getBoolPref("browser.preferences.useOldOrganization")) {
           openPreferences("paneContent", {origin: "browserMedia"});
         } else {
-          openPreferences("panePrivacy", {origin: "browserMedia"});
+          openPreferences("general-drm", {origin: "browserMedia"});
         }
       },
       dismiss: true
     };
     let options = {
       dismissed: true,
       eventCallback: aTopic => aTopic == "swapping",
       learnMoreURL: Services.urlFormatter.formatURLPref("app.support.baseURL") + "drm-content",
--- a/browser/components/newtab/NewTabSearchProvider.jsm
+++ b/browser/components/newtab/NewTabSearchProvider.jsm
@@ -63,21 +63,17 @@ SearchProvider.prototype = {
   },
 
   removeFormHistory({browser}, suggestion) {
     ContentSearch.removeFormHistoryEntry({target: browser}, suggestion);
   },
 
   manageEngines(browser) {
     const browserWin = browser.ownerGlobal;
-    if (Services.prefs.getBoolPref("browser.preferences.useOldOrganization")) {
-      browserWin.openPreferences("paneSearch", { origin: "contentSearch" });
-    } else {
-      browserWin.openPreferences("paneGeneral", { origin: "contentSearch" });
-    }
+    browserWin.openPreferences("paneSearch", { origin: "contentSearch" });
   },
 
   async asyncGetState() {
     let state = await ContentSearch.currentStateObj(true);
     return state;
   },
 
   async asyncPerformSearch({browser}, searchData) {
--- a/browser/components/preferences/in-content-new/main.xul
+++ b/browser/components/preferences/in-content-new/main.xul
@@ -692,17 +692,17 @@
                  accesskey="&actionColumn2.accesskey;" persist="sortDirection"
                  flex="1"/>
     </listheader>
   </richlistbox>
 </groupbox>
 
 
 <!-- DRM Content -->
-<groupbox id="drmGroup" data-category="paneGeneral" hidden="true">
+<groupbox id="drmGroup" data-category="paneGeneral" data-subcategory="drm" hidden="true">
   <caption><label>&drmContent2.label;</label></caption>
   <grid id="contentGrid2">
     <columns>
       <column flex="1"/>
       <column/>
     </columns>
     <rows id="contentRows-2">
       <row id="playDRMContentRow">
--- a/browser/modules/ContentSearch.jsm
+++ b/browser/modules/ContentSearch.jsm
@@ -408,24 +408,18 @@ this.ContentSearch = {
   _onMessageSearch(msg, data) {
     this.performSearch(msg, data);
   },
 
   _onMessageSetCurrentEngine(msg, data) {
     Services.search.currentEngine = Services.search.getEngineByName(data);
   },
 
-  _onMessageManageEngines(msg, data) {
-    let browserWin = msg.target.ownerGlobal;
-    let pref = Services.prefs.getBoolPref("browser.preferences.useOldOrganization");
-    if (pref) {
-      browserWin.openPreferences("paneSearch", {origin: "contentSearch"});
-    } else {
-      browserWin.openPreferences("general-search", {origin: "contentSearch"});
-    }
+  _onMessageManageEngines(msg) {
+    msg.target.ownerGlobal.openPreferences("paneSearch", { origin: "contentSearch" });
   },
 
   async _onMessageGetSuggestions(msg, data) {
     this._ensureDataHasProperties(data, [
       "engineName",
       "searchString",
     ]);
     let {engineName, searchString} = data;