Bug 1384581 - Define a default value for --toolbarbutton-height to prevent CSS errors when the property is applied before the more specific value has been set. r?gijs draft
authorJared Wein <jwein@mozilla.com>
Wed, 26 Jul 2017 10:07:24 -0400
changeset 615873 51369448d02ddfe0dc38a38a861f15b0e85e5760
parent 615853 d3489f06af5f4f864d30c50f53d30f72e4e91ec3
child 639313 9f45f8c2c3a1340876e1261ae9753bd7061868c9
push id70516
push userbmo:jaws@mozilla.com
push dateWed, 26 Jul 2017 14:24:50 +0000
reviewersgijs
bugs1384581
milestone56.0a1
Bug 1384581 - Define a default value for --toolbarbutton-height to prevent CSS errors when the property is applied before the more specific value has been set. r?gijs MozReview-Commit-ID: 55IaJKzILNp
browser/themes/shared/toolbarbuttons.inc.css
--- a/browser/themes/shared/toolbarbuttons.inc.css
+++ b/browser/themes/shared/toolbarbuttons.inc.css
@@ -24,16 +24,22 @@
 %else
   --backbutton-urlbar-overlap: 6px;
 
   /* icon width + border + horizontal padding (without the overlap from backbutton-urlbar-overlap) */
   --forwardbutton-width: 25px;
 
   --toolbarbutton-inner-padding: 3px;
 %endif
+%ifdef MOZ_PHOTON_ANIMATIONS
+  /* This default value of --toolbarbutton-height is defined to prevent
+     CSS errors for an invalid variable. The value should not get used,
+     as a more specific value should be set when the value will be used. */
+  --toolbarbutton-height: 0;
+%endif
 }
 
 /* Larger buttons in touch mode */
 :root[uidensity=touch] {
   --toolbarbutton-inner-padding: 9px;
 }
 
 %ifndef MOZ_PHOTON_THEME