Bug 1383541 - WMFDecoderModule shouldn't call useless IsH264DecoderBlacklisted() - r?jya draft
authorGerald Squelart <gsquelart@mozilla.com>
Tue, 25 Jul 2017 16:46:53 +1200
changeset 615099 1e85ecf0d2a22a5ecfdf258aaefd9358ff256c5d
parent 615098 80394cbcae0f02da8eb801edd92e56f974e5db4f
child 615100 35a0972567e9b427c4bbae31ae87238a05f96f51
push id70238
push usergsquelart@mozilla.com
push dateTue, 25 Jul 2017 12:24:25 +0000
reviewersjya
bugs1383541, 1253395
milestone56.0a1
Bug 1383541 - WMFDecoderModule shouldn't call useless IsH264DecoderBlacklisted() - r?jya This function now always returns false (since bug 1253395), so WMFDecoderModule::HasH264 doesn't need to call it anymore. Note that we are keeping the code, as we will slightly modify it in the next patch for a different use. MozReview-Commit-ID: 7fzktsnFU2m
dom/media/platforms/wmf/WMFDecoderModule.cpp
--- a/dom/media/platforms/wmf/WMFDecoderModule.cpp
+++ b/dom/media/platforms/wmf/WMFDecoderModule.cpp
@@ -189,19 +189,16 @@ IsH264DecoderBlacklisted()
   }
 #endif // BLACKLIST_CRASHY_H264_DECODERS
   return false;
 }
 
 /* static */ bool
 WMFDecoderModule::HasH264()
 {
-  if (IsH264DecoderBlacklisted()) {
-    return false;
-  }
   return CanCreateWMFDecoder<CLSID_CMSH264DecoderMFT>();
 }
 
 /* static */ bool
 WMFDecoderModule::HasAAC()
 {
   return CanCreateWMFDecoder<CLSID_CMSAACDecMFT>();
 }