Bug 1382954 - [Form Autofill] Expand the enable autofill checkbox to full width. r=lchang draft
authorScott Wu <scottcwwu@gmail.com>
Tue, 25 Jul 2017 17:36:22 +0800
changeset 618329 66daa93efc296d898b3c2b8664e920f4cefcf786
parent 618186 6d1b50a370b4adffbb1ee73b9f51707c90d6a2b1
child 618924 02e31f88f08293882929da30191bf262d4c9f618
child 618926 aef29eb523ac95095a2b20f3680fe9e954535119
child 618938 332264edd948c040ee4afb749b3c769250408659
push id71307
push userbmo:scwwu@mozilla.com
push dateMon, 31 Jul 2017 09:34:35 +0000
reviewerslchang
bugs1382954
milestone56.0a1
Bug 1382954 - [Form Autofill] Expand the enable autofill checkbox to full width. r=lchang MozReview-Commit-ID: 1ZTiXIWRA9O
browser/extensions/formautofill/FormAutofillPreferences.jsm
--- a/browser/extensions/formautofill/FormAutofillPreferences.jsm
+++ b/browser/extensions/formautofill/FormAutofillPreferences.jsm
@@ -65,17 +65,16 @@ FormAutofillPreferences.prototype = {
    * Create Form Autofill preference group
    *
    * @param  {XULDocument} document
    */
   createPreferenceGroup(document) {
     let formAutofillGroup;
     let addressAutofill = document.createElementNS(XUL_NS, "hbox");
     let addressAutofillCheckbox = document.createElementNS(XUL_NS, "checkbox");
-    let spacer = document.createElementNS(XUL_NS, "spacer");
     let savedAddressesBtn = document.createElementNS(XUL_NS, "button");
 
     if (this.useOldOrganization) {
       let caption = document.createElementNS(XUL_NS, "caption");
       let captionLabel = document.createElementNS(XUL_NS, "label");
 
       formAutofillGroup = document.createElementNS(XUL_NS, "groupbox");
       formAutofillGroup.hidden = document.location.href != "about:preferences#privacy";
@@ -100,21 +99,20 @@ FormAutofillPreferences.prototype = {
     savedAddressesBtn.setAttribute("label", this.bundle.GetStringFromName("savedAddresses"));
     addressAutofillCheckbox.setAttribute("label", this.bundle.GetStringFromName("enableAddressAutofill"));
 
     // Manually set the checked state
     if (this.isAutofillEnabled) {
       addressAutofillCheckbox.setAttribute("checked", true);
     }
 
-    spacer.flex = 1;
+    addressAutofillCheckbox.flex = 1;
 
     formAutofillGroup.appendChild(addressAutofill);
     addressAutofill.appendChild(addressAutofillCheckbox);
-    addressAutofill.appendChild(spacer);
     addressAutofill.appendChild(savedAddressesBtn);
   },
 
   /**
    * Handle events
    *
    * @param  {DOMEvent} event
    */