Bug 1383904 - Show old elevation dialog on elevation fail r?rstrong draft
authorDoug Thayer <dothayer@mozilla.com>
Mon, 24 Jul 2017 13:48:44 -0700
changeset 614731 2a76ee1ae9dc96ed117bbac65905c0e5f8abf42b
parent 614730 bf4634a50775537b4e791b6d294a275b83737472
child 638936 836c540b790b3382e0d5e8c485ce3bb939cce1e0
push id70093
push userbmo:dothayer@mozilla.com
push dateMon, 24 Jul 2017 22:08:38 +0000
reviewersrstrong
bugs1383904
milestone56.0a1
Bug 1383904 - Show old elevation dialog on elevation fail r?rstrong The patch which originally disabled this seems to have been in error, thinking it was the cause of failing tests on try. Can't provide much more context than that. MozReview-Commit-ID: 9h1pXVJeDCG
toolkit/mozapps/update/nsUpdateService.js
--- a/toolkit/mozapps/update/nsUpdateService.js
+++ b/toolkit/mozapps/update/nsUpdateService.js
@@ -3794,17 +3794,16 @@ UpdatePrompt.prototype = {
                  "Update:History", null, null);
   },
 
   /**
    * See nsIUpdateService.idl
    */
   showUpdateElevationRequired: function UP_showUpdateElevationRequired() {
     if (getPref("getBoolPref", PREF_APP_UPDATE_SILENT, false) ||
-        getPref("getBoolPref", PREF_APP_UPDATE_DOORHANGER, false) ||
         this._getAltUpdateWindow()) {
       return;
     }
 
     let um = Cc["@mozilla.org/updates/update-manager;1"].
              getService(Ci.nsIUpdateManager);
     this._showUI(null, URI_UPDATE_PROMPT_DIALOG, null,
                  UPDATE_WINDOW_NAME, "finishedBackground", um.activeUpdate);