Bug 1373449 Treat complete themes as legacy extensions draft
authorAndrew Swan <aswan@mozilla.com>
Sat, 22 Jul 2017 19:37:48 -0700
changeset 613834 44775ab5b6230e7e517f9b22dfc688d961012055
parent 613800 c22502562670e5e53bea543a3ee25c81f1a7b624
child 638731 1cf0bfa267791b6abbb4c9c176951bb8a078a40f
push id69864
push useraswan@mozilla.com
push dateSun, 23 Jul 2017 02:52:49 +0000
bugs1373449
milestone56.0a1
Bug 1373449 Treat complete themes as legacy extensions MozReview-Commit-ID: I1AH07QSLNK
toolkit/mozapps/extensions/internal/XPIProvider.jsm
toolkit/mozapps/extensions/test/xpcshell/test_legacy.js
--- a/toolkit/mozapps/extensions/internal/XPIProvider.jsm
+++ b/toolkit/mozapps/extensions/internal/XPIProvider.jsm
@@ -260,16 +260,17 @@ const SIGNED_TYPES = new Set([
   "experiment",
   "webextension",
   "webextension-theme",
 ]);
 
 const LEGACY_TYPES = new Set([
   "apiextension",
   "extension",
+  "theme",
 ]);
 
 const ALL_EXTERNAL_TYPES = new Set([
   "dictionary",
   "extension",
   "experiment",
   "locale",
   "theme",
--- a/toolkit/mozapps/extensions/test/xpcshell/test_legacy.js
+++ b/toolkit/mozapps/extensions/test/xpcshell/test_legacy.js
@@ -14,16 +14,23 @@ add_task(async function test_disable() {
       multiprocessCompatible: true,
     },
     {
       id: "apiexperiment@tests.mozilla.org",
       name: "WebExtension Experiment",
       version: "1.0",
       type: 256,
     },
+    {
+      id: "theme@tests.mozilla.org",
+      name: "Theme",
+      version: "1.0",
+      type: 4,
+      internalName: "mytheme/1.0",
+    },
   ];
 
   let nonLegacy = [
     {
       id: "webextension@tests.mozilla.org",
       manifest: {
         applications: {gecko: {id: "webextension@tests.mozilla.org"}},
       },