Bug 1383001: Stop claiming to support unstyled children traversals for throttled animations. r?heycam draft
authorEmilio Cobos Álvarez <emilio@crisal.io>
Sat, 22 Jul 2017 01:32:05 +0200
changeset 613451 d3e54004627bc52e81f32c6ce45114b813569cca
parent 613078 fb06233940bb2b86aa2f6e96794317ca36e5182d
child 613452 f8e46b0c5c8124da900022c5e62c60c198ddf182
push id69804
push userbmo:emilio+bugs@crisal.io
push dateFri, 21 Jul 2017 23:36:19 +0000
reviewersheycam
bugs1383001
milestone56.0a1
Bug 1383001: Stop claiming to support unstyled children traversals for throttled animations. r?heycam The whole concept made me laugh a bit actually :) MozReview-Commit-ID: 1KJrUYuaHxL
servo/ports/geckolib/glue.rs
--- a/servo/ports/geckolib/glue.rs
+++ b/servo/ports/geckolib/glue.rs
@@ -263,18 +263,17 @@ pub extern "C" fn Servo_TraverseSubtree(
     debug!("Servo_TraverseSubtree: {:?} {:?}", element, restyle_behavior);
 
     let traversal_flags = match (root_behavior, restyle_behavior) {
         (Root::Normal, Restyle::Normal) |
         (Root::Normal, Restyle::ForNewlyBoundElement) |
         (Root::Normal, Restyle::ForThrottledAnimationFlush)
             => TraversalFlags::empty(),
         (Root::UnstyledChildrenOnly, Restyle::Normal) |
-        (Root::UnstyledChildrenOnly, Restyle::ForNewlyBoundElement) |
-        (Root::UnstyledChildrenOnly, Restyle::ForThrottledAnimationFlush)
+        (Root::UnstyledChildrenOnly, Restyle::ForNewlyBoundElement)
             => UNSTYLED_CHILDREN_ONLY,
         (Root::Normal, Restyle::ForCSSRuleChanges) => FOR_CSS_RULE_CHANGES,
         (Root::Normal, Restyle::ForReconstruct) => FOR_RECONSTRUCT,
         _ => panic!("invalid combination of TraversalRootBehavior and TraversalRestyleBehavior"),
     };
 
     let needs_animation_only_restyle = element.has_animation_only_dirty_descendants() ||
                                        element.has_animation_restyle_hints();