Bug 1381577 - Part J; Sign setup.exe on windows and error if we try to sign an unknown platform. r=kmoir draft
authorJustin Wood <Callek@gmail.com>
Fri, 21 Jul 2017 14:17:16 -0400
changeset 613352 a900c4b8cd0bab92fa7104a0b0b53bb29d6a2450
parent 613351 c6f68a8b3621b3a743d1f1eb4a6857d23dd801b7
child 613353 6d0b167fd8809f6d2b8c876929ed98e2dbb275fe
push id69770
push userCallek@gmail.com
push dateFri, 21 Jul 2017 20:09:14 +0000
reviewerskmoir
bugs1381577
milestone56.0a1
Bug 1381577 - Part J; Sign setup.exe on windows and error if we try to sign an unknown platform. r=kmoir Land date changes to support windows nightlies onto central MozReview-Commit-ID: KFQDaaX2P8v
taskcluster/taskgraph/transforms/build_signing.py
--- a/taskcluster/taskgraph/transforms/build_signing.py
+++ b/taskcluster/taskgraph/transforms/build_signing.py
@@ -64,28 +64,43 @@ def _generate_upstream_artifacts(build_p
         }]
     # XXX: Mac and Windows don't sign mars because internal aren't signed at
     # this stage of the release
     elif 'macosx' in build_platform:
         artifacts_specificities = [{
             'artifacts': ['public/build/target.dmg'],
             'format': 'macapp',
         }]
-    elif 'win' in build_platform:
+    elif 'win64' in build_platform:
         artifacts_specificities = [{
-            'artifacts': ['public/build/target.zip'],
+            'artifacts': [
+                'public/build/target.zip',
+                'public/build/setup.exe'
+            ],
             'format': 'sha2signcode',
         }]
-    else:
+    elif 'win32' in build_platform:
+        artifacts_specificities = [{
+            'artifacts': [
+                'public/build/target.zip',
+                'public/build/setup.exe',
+                ],
+            'format': 'sha2signcode',
+        }]
+        if is_nightly:
+            artifacts_specificities[0]['artifacts'] += ['public/build/setup-stub.exe']
+    elif 'linux' in build_platform:
         artifacts_specificities = [{
             'artifacts': ['public/build/target.tar.bz2'],
             'format': 'gpg',
         }, {
             'artifacts': ['public/build/update/target.complete.mar'],
             'format': 'mar',
         }]
+    else:
+        raise Exception("Platform not implemented for signing")
 
     return [{
         'taskId': {'task-reference': '<build>'},
         'taskType': 'build',
         'paths': specificity['artifacts'],
         'formats': [specificity['format']],
     } for specificity in artifacts_specificities]