Bug 1380133 - Part 10: Whitelist nsStyleContext::PeekStyleXXX for heap writes. r?heycam draft
authorCameron McCormack <cam@mcc.id.au>
Fri, 21 Jul 2017 11:51:04 +0800
changeset 612852 d9818efdf47e4f8bbafbccd96a66ee4193c2faff
parent 612851 3e6da1f13dbd2767787d6d9b7f2553949e3d0ad2
child 638513 1108a8818189258ea7e1b3599c589460b98578ce
push id69615
push userbmo:cam@mcc.id.au
push dateFri, 21 Jul 2017 03:51:35 +0000
reviewersheycam
bugs1380133
milestone56.0a1
Bug 1380133 - Part 10: Whitelist nsStyleContext::PeekStyleXXX for heap writes. r?heycam MozReview-Commit-ID: BLlJm7JUnOq
js/src/devtools/rootAnalysis/analyzeHeapWrites.js
--- a/js/src/devtools/rootAnalysis/analyzeHeapWrites.js
+++ b/js/src/devtools/rootAnalysis/analyzeHeapWrites.js
@@ -408,16 +408,20 @@ function ignoreContents(entry)
         "Gecko_CSSValue_SetArray",
         "Gecko_CSSValue_InitSharedList",
         "Gecko_EnsureMozBorderColors",
         "Gecko_ClearMozBorderColors",
         "Gecko_AppendMozBorderColors",
         "Gecko_CopyMozBorderColors",
         "Gecko_SetNullImageValue",
 
+        // The analysis thinks we'll write to mBits in the DoGetStyleFoo<false>
+        // call.  Maybe the template parameter confuses it?
+        /nsStyleContext::PeekStyle/,
+
         // Needs main thread assertions or other fixes.
         /UndisplayedMap::GetEntryFor/,
         /nsStyleContext::CalcStyleDifferenceInternal/,
         /EffectCompositor::GetServoAnimationRule/,
         /LookAndFeel::GetColor/,
         "Gecko_CopyStyleContentsFrom",
         "Gecko_CSSValue_SetAbsoluteLength",
         "Gecko_UnsetDirtyStyleAttr",