Bug 1382863 Part 1: Move MessagePortChild constructor out of inline, creating a vtable needed for clang compilation. draft
authorBrad Werth <bwerth@mozilla.com>
Thu, 20 Jul 2017 15:45:30 -0700
changeset 612672 23829626bca48fa8ac30f56f9e58e15f66589a7e
parent 612315 d3ebc6448a62d38b134e957eb4fd5c2565ad40b8
child 638467 597011ec4586b9ac1dbd369c3fed4505087a138b
push id69562
push userbwerth@mozilla.com
push dateThu, 20 Jul 2017 22:58:35 +0000
bugs1382863
milestone56.0a1
Bug 1382863 Part 1: Move MessagePortChild constructor out of inline, creating a vtable needed for clang compilation. MozReview-Commit-ID: 6xO9s3qlqJq
dom/messagechannel/MessagePortChild.cpp
dom/messagechannel/MessagePortChild.h
--- a/dom/messagechannel/MessagePortChild.cpp
+++ b/dom/messagechannel/MessagePortChild.cpp
@@ -6,16 +6,21 @@
 #include "MessagePortChild.h"
 #include "MessagePort.h"
 #include "mozilla/dom/MessageEvent.h"
 #include "mozilla/ipc/PBackgroundChild.h"
 
 namespace mozilla {
 namespace dom {
 
+MessagePortChild::MessagePortChild()
+  : mPort(nullptr)
+{
+}
+
 mozilla::ipc::IPCResult
 MessagePortChild::RecvStopSendingDataConfirmed()
 {
   MOZ_ASSERT(mPort);
   mPort->StopSendingDataConfirmed();
   MOZ_ASSERT(!mPort);
   return IPC_OK();
 }
--- a/dom/messagechannel/MessagePortChild.h
+++ b/dom/messagechannel/MessagePortChild.h
@@ -14,17 +14,17 @@ namespace dom {
 
 class MessagePort;
 
 class MessagePortChild final : public PMessagePortChild
 {
 public:
   NS_INLINE_DECL_REFCOUNTING(MessagePortChild)
 
-  MessagePortChild() : mPort(nullptr) {}
+  MessagePortChild();
 
   void SetPort(MessagePort* aPort)
   {
     mPort = aPort;
   }
 
 private:
   ~MessagePortChild()