Bug 1316211. P9 - remove SizeOf{Audio,Video}QueueInBytes() that has no callers. draft
authorJW Wang <jwwang@mozilla.com>
Wed, 19 Jul 2017 15:08:27 +0800
changeset 611843 40f5d605ddffc0e85ff77e9cbee99b5b6be23eaa
parent 611842 e975fdb1bc77ed030c472a845386f965a9c93615
child 611844 81fc29e73e56eb0e0e4aa40116f64b333bdf33ac
push id69302
push userjwwang@mozilla.com
push dateThu, 20 Jul 2017 02:52:36 +0000
bugs1316211
milestone56.0a1
Bug 1316211. P9 - remove SizeOf{Audio,Video}QueueInBytes() that has no callers. MozReview-Commit-ID: A6TbGMdyDGQ
dom/media/MediaDecoderReader.cpp
dom/media/MediaDecoderReader.h
dom/media/MediaDecoderReaderWrapper.h
--- a/dom/media/MediaDecoderReader.cpp
+++ b/dom/media/MediaDecoderReader.cpp
@@ -58,26 +58,16 @@ MediaDecoderReader::Init()
 }
 
 MediaDecoderReader::~MediaDecoderReader()
 {
   MOZ_ASSERT(mShutdown);
   MOZ_COUNT_DTOR(MediaDecoderReader);
 }
 
-size_t MediaDecoderReader::SizeOfVideoQueueInBytes() const
-{
-  return 0;
-}
-
-size_t MediaDecoderReader::SizeOfAudioQueueInBytes() const
-{
-  return 0;
-}
-
 size_t MediaDecoderReader::SizeOfVideoQueueInFrames()
 {
   return 0;
 }
 
 size_t MediaDecoderReader::SizeOfAudioQueueInFrames()
 {
   return 0;
--- a/dom/media/MediaDecoderReader.h
+++ b/dom/media/MediaDecoderReader.h
@@ -190,24 +190,16 @@ public:
   }
 
   // The MediaDecoderStateMachine uses various heuristics that assume that
   // raw media data is arriving sequentially from a network channel. This
   // makes sense in the <video src="foo"> case, but not for more advanced use
   // cases like MSE.
   virtual bool UseBufferingHeuristics() const = 0;
 
-  // Returns the number of bytes of memory allocated by structures/frames in
-  // the video queue.
-  size_t SizeOfVideoQueueInBytes() const;
-
-  // Returns the number of bytes of memory allocated by structures/frames in
-  // the audio queue.
-  size_t SizeOfAudioQueueInBytes() const;
-
   virtual size_t SizeOfVideoQueueInFrames();
   virtual size_t SizeOfAudioQueueInFrames();
 
   // Called once new data has been cached by the MediaResource.
   // mBuffered should be recalculated and updated accordingly.
   virtual void NotifyDataArrived() = 0;
 
   AbstractCanonical<media::TimeIntervals>* CanonicalBuffered()
--- a/dom/media/MediaDecoderReaderWrapper.h
+++ b/dom/media/MediaDecoderReaderWrapper.h
@@ -59,22 +59,16 @@ public:
     return mReader->VideoIsHardwareAccelerated();
   }
   TimedMetadataEventSource& TimedMetadataEvent() {
     return mReader->TimedMetadataEvent();
   }
   MediaEventSource<void>& OnMediaNotSeekable() {
     return mReader->OnMediaNotSeekable();
   }
-  size_t SizeOfVideoQueueInBytes() const {
-    return mReader->SizeOfVideoQueueInBytes();
-  }
-  size_t SizeOfAudioQueueInBytes() const {
-    return mReader->SizeOfAudioQueueInBytes();
-  }
   size_t SizeOfAudioQueueInFrames() const {
     return mReader->SizeOfAudioQueueInFrames();
   }
   size_t SizeOfVideoQueueInFrames() const {
     return mReader->SizeOfVideoQueueInFrames();
   }
   void ReadUpdatedMetadata(MediaInfo* aInfo) {
     mReader->ReadUpdatedMetadata(aInfo);