Bug 1330146. Remove windows-xp and windows-vista as values for -moz-os-version from tests. r=dholbert draft
authorMike Taylor <miket@mozilla.com>
Wed, 19 Jul 2017 11:44:24 -0500
changeset 611472 4e17055670191142c43c8df9efd4d343f530090d
parent 611471 64b0ca57d543ee0c4f2c8268d7fe4af118b0f434
child 638166 1382a82fdb46da9132008f67b99d37a562bab0f8
push id69225
push userbmo:miket@mozilla.com
push dateWed, 19 Jul 2017 18:54:24 +0000
reviewersdholbert
bugs1330146, 1325503
milestone56.0a1
Bug 1330146. Remove windows-xp and windows-vista as values for -moz-os-version from tests. r=dholbert The functionality was removed in Bug 1325503. The reason these tests didn't start failing is because they just test the parsability of the media feature and its' value, not that it does anything useful. MozReview-Commit-ID: 6a0nlKhUZTQ
layout/style/test/chrome/bug418986-2.js
layout/style/test/test_media_queries.html
--- a/layout/style/test/chrome/bug418986-2.js
+++ b/layout/style/test/chrome/bug418986-2.js
@@ -48,18 +48,16 @@ var suppressed_toggles = [
   "-moz-touch-enabled",
   "-moz-windows-compositor",
   "-moz-windows-default-theme",
   "-moz-windows-glass",
 ];
 
 // Possible values for '-moz-os-version'
 var windows_versions = [
-  "windows-xp",
-  "windows-vista",
   "windows-win7",
   "windows-win8",
   "windows-win10",
 ];
 
 // Possible values for '-moz-windows-theme'
 var windows_themes = [
   "aero",
--- a/layout/style/test/test_media_queries.html
+++ b/layout/style/test/test_media_queries.html
@@ -708,18 +708,16 @@ function run() {
   expression_should_be_parseable("-moz-windows-theme: royale");
   expression_should_be_parseable("-moz-windows-theme: generic");
   expression_should_be_parseable("-moz-windows-theme: zune");
   expression_should_be_parseable("-moz-windows-theme: garbage");
   expression_should_not_be_parseable("-moz-windows-theme: ''");
   expression_should_not_be_parseable("-moz-windows-theme: ");
 
   // os version media queries (currently windows only)
-  expression_should_be_parseable("-moz-os-version: windows-xp");
-  expression_should_be_parseable("-moz-os-version: windows-vista");
   expression_should_be_parseable("-moz-os-version: windows-win7");
   expression_should_be_parseable("-moz-os-version: windows-win8");
   expression_should_be_parseable("-moz-os-version: windows-win10");
   expression_should_not_be_parseable("-moz-os-version: ");
 
   // OpenType SVG media features
   query_should_be_parseable("(-moz-is-glyph)");
   query_should_not_be_parseable("not (-moz-is-glyph)");