Bug 1377216 - Unset MOZ_AUTOMATION when building SpiderMonkey from package; r?glandium draft
authorGregory Szorc <gps@mozilla.com>
Tue, 18 Jul 2017 17:39:27 -0700
changeset 610942 c84fee99ef97481f241c478c58453df2ece03bdd
parent 609865 e0b0865639cebc1b5afa0268a4b073fcdde0e69c
child 610943 f1ad72cab0c5d21a5050d8632499d2fb5ba70cd9
child 610964 212f03efaa5d4a10f288ba69711d99f934225949
push id69063
push userbmo:gps@mozilla.com
push dateWed, 19 Jul 2017 00:40:35 +0000
reviewersglandium
bugs1377216
milestone56.0a1
Bug 1377216 - Unset MOZ_AUTOMATION when building SpiderMonkey from package; r?glandium We're about to make MOZ_AUTOMATION more strict about things like having a source checkout. The whole point of build-sm-package.sh is to verify that SpiderMonkey can be built outside of Mozilla's source repo and automation from a standalone package. Since the presence of MOZ_AUTOMATION can influence so much behavior in the build system, unset it so that the job tests a !Mozilla environment more accurately. MozReview-Commit-ID: EMfyLKfY0uU
taskcluster/scripts/builder/build-sm-package.sh
--- a/taskcluster/scripts/builder/build-sm-package.sh
+++ b/taskcluster/scripts/builder/build-sm-package.sh
@@ -16,13 +16,18 @@ mkdir -p $PACKAGE_DIR
 pushd $PACKAGE_DIR
 
 tar -xjvf $UPLOAD_DIR/mozjs-*.tar.bz2
 
 : ${PYTHON:=python2.7}
 
 # Build the freshly extracted, packaged SpiderMonkey.
 pushd ./mozjs-*/js/src
+
+# MOZ_AUTOMATION enforces certain requirements that don't apply to
+# packaged builds. Unset it.
+unset MOZ_AUTOMATION
+
 AUTOMATION=1 $PYTHON ./devtools/automation/autospider.py --skip-tests=checks $SPIDERMONKEY_VARIANT
 popd
 
 # Copy artifacts for upload by TaskCluster
 cp -rL ./mozjs-*/obj-spider/dist/bin/{js,jsapi-tests,js-gdb.py,libmozjs*} $UPLOAD_DIR