Bug 1379280 - Move FocusTarget include from nsIPresShell to PresShell. r?smaug draft
authorRyan Hunt <rhunt@eqrion.net>
Thu, 13 Jul 2017 13:00:21 -0500
changeset 610297 a84f1f9bf145338dc2eccef28fe6fbaaa42369a4
parent 609768 d43779e278d2e4d3e21dba2fcb585a3bf4b1288e
child 610298 09a73d3ccb6cd94a71edab9c19182068dfa25d64
push id68842
push userbmo:rhunt@eqrion.net
push dateTue, 18 Jul 2017 05:12:46 +0000
reviewerssmaug
bugs1379280
milestone56.0a1
Bug 1379280 - Move FocusTarget include from nsIPresShell to PresShell. r?smaug FocusTarget used to be needed in nsIPresShell, but it was moved to PresShell. MozReview-Commit-ID: HQFpT9OJaUz
layout/base/PresShell.h
layout/base/nsIPresShell.h
--- a/layout/base/PresShell.h
+++ b/layout/base/PresShell.h
@@ -19,16 +19,17 @@
 /* a presentation of a document, part 2 */
 
 #ifndef mozilla_PresShell_h
 #define mozilla_PresShell_h
 
 #include "MobileViewportManager.h"
 #include "mozilla/Attributes.h"
 #include "mozilla/EventForwards.h"
+#include "mozilla/layers/FocusTarget.h"
 #include "mozilla/MemoryReporting.h"
 #include "mozilla/StyleSetHandle.h"
 #include "mozilla/UniquePtr.h"
 #include "nsAutoPtr.h"
 #include "nsContentUtils.h" // For AddScriptBlocker().
 #include "nsCRT.h"
 #include "nsIObserver.h"
 #include "nsIPresShell.h"
@@ -80,16 +81,19 @@ typedef nsClassHashtable<nsUint64HashKey
 #endif
 
 class PresShell final : public nsIPresShell,
                         public nsStubDocumentObserver,
                         public nsISelectionController,
                         public nsIObserver,
                         public nsSupportsWeakReference
 {
+protected:
+  typedef mozilla::layers::FocusTarget FocusTarget;
+
 public:
   PresShell();
 
   // nsISupports
   NS_DECL_ISUPPORTS
 
   static bool AccessibleCaretEnabled(nsIDocShell* aDocShell);
 
--- a/layout/base/nsIPresShell.h
+++ b/layout/base/nsIPresShell.h
@@ -18,17 +18,16 @@
 /* a presentation of a document, part 2 */
 
 #ifndef nsIPresShell_h___
 #define nsIPresShell_h___
 
 #include "mozilla/ArenaObjectID.h"
 #include "mozilla/EventForwards.h"
 #include "mozilla/FlushType.h"
-#include "mozilla/layers/FocusTarget.h"
 #include "mozilla/MemoryReporting.h"
 #include "mozilla/StaticPtr.h"
 #include "mozilla/StyleSetHandle.h"
 #include "mozilla/StyleSheet.h"
 #include "mozilla/WeakPtr.h"
 #include "gfxPoint.h"
 #include "nsTHashtable.h"
 #include "nsHashKeys.h"
@@ -176,17 +175,16 @@ enum nsRectVisibility {
  */
 
 class nsIPresShell : public nsISupports
 {
 public:
   NS_DECLARE_STATIC_IID_ACCESSOR(NS_IPRESSHELL_IID)
 
 protected:
-  typedef mozilla::layers::FocusTarget FocusTarget;
   typedef mozilla::layers::LayerManager LayerManager;
   typedef mozilla::gfx::SourceSurface SourceSurface;
 
   enum eRenderFlag {
     STATE_IGNORING_VIEWPORT_SCROLLING = 0x1,
     STATE_DRAWWINDOW_NOT_FLUSHING = 0x2
   };
   typedef uint8_t RenderFlags; // for storing the above flags