Bug 1381584 - Remove unused cite field from nsIDOMHTMLQuoteElement. r=bz draft
authorAndrew McCreight <continuation@gmail.com>
Mon, 17 Jul 2017 12:36:41 -0700
changeset 609979 1cbef35cbab926546c224c3d79a722624dc9901d
parent 609865 e0b0865639cebc1b5afa0268a4b073fcdde0e69c
child 610007 8a0af2707997b3f2087b8d0a012ce37418654967
push id68746
push userbmo:continuation@gmail.com
push dateMon, 17 Jul 2017 19:41:27 +0000
reviewersbz
bugs1381584
milestone56.0a1
Bug 1381584 - Remove unused cite field from nsIDOMHTMLQuoteElement. r=bz MozReview-Commit-ID: 2sKSRcl6B1W
dom/html/HTMLSharedElement.cpp
dom/html/HTMLSharedElement.h
dom/interfaces/html/nsIDOMHTMLQuoteElement.idl
--- a/dom/html/HTMLSharedElement.cpp
+++ b/dom/html/HTMLSharedElement.cpp
@@ -43,17 +43,17 @@ NS_INTERFACE_MAP_BEGIN(HTMLSharedElement
   NS_INTERFACE_MAP_ENTRY_IF_TAG(nsIDOMHTMLHeadElement, head)
   NS_INTERFACE_MAP_ENTRY_IF_TAG(nsIDOMHTMLHtmlElement, html)
 NS_INTERFACE_MAP_END_INHERITING(nsGenericHTMLElement)
 
 
 NS_IMPL_ELEMENT_CLONE(HTMLSharedElement)
 
 // nsIDOMHTMLQuoteElement
-NS_IMPL_URI_ATTR(HTMLSharedElement, Cite, cite)
+// Empty
 
 // nsIDOMHTMLHeadElement
 // Empty
 
 // nsIDOMHTMLHtmlElement
 NS_IMPL_STRING_ATTR(HTMLSharedElement, Version, version)
 
 // nsIDOMHTMLBaseElement
--- a/dom/html/HTMLSharedElement.h
+++ b/dom/html/HTMLSharedElement.h
@@ -142,17 +142,21 @@ public:
   }
   void SetCompact(bool aCompact, ErrorResult& aResult)
   {
     MOZ_ASSERT(mNodeInfo->Equals(nsGkAtoms::dir));
     SetHTMLBoolAttr(nsGkAtoms::compact, aCompact, aResult);
   }
 
   // HTMLQuoteElement
-  // The XPCOM GetCite works fine for us
+  void GetCite(nsString& aCite)
+  {
+    GetHTMLURIAttr(nsGkAtoms::cite, aCite);
+  }
+
   void SetCite(const nsAString& aValue, ErrorResult& aResult)
   {
     MOZ_ASSERT(mNodeInfo->Equals(nsGkAtoms::q) ||
                mNodeInfo->Equals(nsGkAtoms::blockquote));
     SetHTMLAttr(nsGkAtoms::cite, aValue, aResult);
   }
 
   // HTMLHtmlElement
--- a/dom/interfaces/html/nsIDOMHTMLQuoteElement.idl
+++ b/dom/interfaces/html/nsIDOMHTMLQuoteElement.idl
@@ -1,23 +1,11 @@
 /* -*- Mode: IDL; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
 /* This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
-#include "nsIDOMHTMLElement.idl"
-
-/**
- * The nsIDOMHTMLQuoteElement interface is the interface to a [X]HTML
- * q element.
- *
- * This interface is trying to follow the DOM Level 2 HTML specification:
- * http://www.w3.org/TR/DOM-Level-2-HTML/
- *
- * with changes from the work-in-progress WHATWG HTML specification:
- * http://www.whatwg.org/specs/web-apps/current-work/
- */
+#include "nsISupports.idl"
 
 [uuid(f02502b5-32a6-4df7-8a57-1416553a3188)]
 interface nsIDOMHTMLQuoteElement : nsISupports
 {
-           attribute DOMString        cite;
 };