Bug 1381364 - Update Overlay heading string;r=mossop draft
authorgasolin <gasolin@gmail.com>
Mon, 17 Jul 2017 12:00:06 +0800
changeset 609625 d4a1a68d626dd20933e7f4f76be650387961ab20
parent 609596 aff336ac161daa3ea350e59a288963edbd58ed39
child 637598 c9436ee13cdf8b9a8509aaf756f9fe619871bd32
push id68607
push userbmo:gasolin@mozilla.com
push dateMon, 17 Jul 2017 04:00:23 +0000
reviewersmossop
bugs1381364
milestone56.0a1
Bug 1381364 - Update Overlay heading string;r=mossop MozReview-Commit-ID: 1DreCCN0SYg
browser/extensions/onboarding/content/onboarding.js
browser/extensions/onboarding/locales/en-US/onboarding.properties
--- a/browser/extensions/onboarding/content/onboarding.js
+++ b/browser/extensions/onboarding/content/onboarding.js
@@ -685,17 +685,17 @@ class Onboarding {
           <input type="checkbox" id="onboarding-tour-hidden-checkbox" /><label for="onboarding-tour-hidden-checkbox"></label>
         </footer>
       </div>
     `;
 
     div.querySelector("label[for='onboarding-tour-hidden-checkbox']").textContent =
        this._bundle.GetStringFromName("onboarding.hidden-checkbox-label-text");
     div.querySelector("#onboarding-header").textContent =
-       this._bundle.formatStringFromName("onboarding.overlay-title", [BRAND_SHORT_NAME], 1);
+       this._bundle.GetStringFromName("onboarding.overlay-title2");
     return div;
   }
 
   _renderOverlayIcon() {
     let img = this._window.document.createElement("div");
     img.id = "onboarding-overlay-icon";
     return img;
   }
--- a/browser/extensions/onboarding/locales/en-US/onboarding.properties
+++ b/browser/extensions/onboarding/locales/en-US/onboarding.properties
@@ -1,13 +1,13 @@
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
-# LOCALIZATION NOTE(onboarding.overlay-title): This string will be used in the overlay title. %S is brandShortName
-onboarding.overlay-title=Getting started with %S
+# LOCALIZATION NOTE(onboarding.overlay-title2): This string will be used in the overlay title.
+onboarding.overlay-title2=Let’s get started
 onboarding.hidden-checkbox-label-text=Mark all as complete, and hide the tour
 #LOCALIZATION NOTE(onboarding.button.learnMore): this string is used as a button label, displayed near the message, and shared across all the onboarding notifications.
 onboarding.button.learnMore=Learn More
 # LOCALIZATION NOTE(onboarding.notification-icon-tool-tip): This string will be used to show the tooltip alongside the notification icon. %S is brandShortName.
 onboarding.notification-icon-tool-tip=New to %S?
 
 onboarding.tour-search2=Search
 onboarding.tour-search.title2=Find it faster.