Bug 1375280 - Force remote debugging prefs off if jsdebugger isn't requested for marionette-test;r=chmanchester draft
authorBrian Grinstead <bgrinstead@mozilla.com>
Fri, 14 Jul 2017 07:38:12 -0700
changeset 609015 5b3145016664050f6ab345d1216e6d24d64c4452
parent 609012 c2ae3fcd41b8fbe66e966453d3dd99866687c085
child 609016 57739bbc25a881ad52650421b17a2b8762a18cea
push id68473
push userbgrinstead@mozilla.com
push dateFri, 14 Jul 2017 14:38:23 +0000
reviewerschmanchester
bugs1375280
milestone56.0a1
Bug 1375280 - Force remote debugging prefs off if jsdebugger isn't requested for marionette-test;r=chmanchester Since the remote debugging pref defaults will be set to true in local builds, force them off for tests unless --jsdebugger is passed, to limit differences locally and in automation. MozReview-Commit-ID: 3isiIAvAGfk
testing/marionette/client/marionette_driver/geckoinstance.py
--- a/testing/marionette/client/marionette_driver/geckoinstance.py
+++ b/testing/marionette/client/marionette_driver/geckoinstance.py
@@ -173,16 +173,22 @@ class GeckoInstance(object):
         if "-jsdebugger" in self.app_args:
             profile_args["preferences"].update({
                 "devtools.browsertoolbox.panel": "jsdebugger",
                 "devtools.debugger.remote-enabled": True,
                 "devtools.chrome.enabled": True,
                 "devtools.debugger.prompt-connection": False,
                 "marionette.debugging.clicktostart": True,
             })
+        else:
+            profile_args["preferences"].update({
+                "devtools.debugger.remote-enabled": False,
+                "devtools.chrome.enabled": False,
+                "devtools.debugger.prompt-connection": True,
+            })
         if self.addons:
             profile_args["addons"] = self.addons
 
         if hasattr(self, "profile_path") and self.profile is None:
             if not self.profile_path:
                 if self.workspace:
                     profile_args["profile"] = tempfile.mkdtemp(
                         suffix=".mozrunner-{:.0f}".format(time.time()),