Bug 1375280 - Force remote debugging prefs off if jsdebugger isn't requested for mochitests;r=jryans draft
authorBrian Grinstead <bgrinstead@mozilla.com>
Fri, 14 Jul 2017 07:36:17 -0700
changeset 609012 c2ae3fcd41b8fbe66e966453d3dd99866687c085
parent 607503 09a4282d1172ac255038e7ccacfd772140b219e2
child 609013 d8912d4718d22e8d82d9517f119f0b7ae8861192
child 609015 5b3145016664050f6ab345d1216e6d24d64c4452
push id68472
push userbgrinstead@mozilla.com
push dateFri, 14 Jul 2017 14:37:01 +0000
reviewersjryans
bugs1375280
milestone56.0a1
Bug 1375280 - Force remote debugging prefs off if jsdebugger isn't requested for mochitests;r=jryans Since the remote debugging pref defaults will be set to true in local builds, force them off for tests unless --jsdebugger is passed, to limit differences locally and in automation. MozReview-Commit-ID: KmkXAGhFXhf
testing/mochitest/mochitest_options.py
--- a/testing/mochitest/mochitest_options.py
+++ b/testing/mochitest/mochitest_options.py
@@ -727,16 +727,22 @@ class MochitestArguments(ArgumentContain
             options.symbolsPath = os.path.join(build_obj.distdir, 'crashreporter-symbols')
 
         if options.jsdebugger:
             options.extraPrefs += [
                 "devtools.debugger.remote-enabled=true",
                 "devtools.chrome.enabled=true",
                 "devtools.debugger.prompt-connection=false"
             ]
+        else:
+            options.extraPrefs += [
+                "devtools.debugger.remote-enabled=false",
+                "devtools.chrome.enabled=false",
+                "devtools.debugger.prompt-connection=true"
+            ]
 
         if options.debugOnFailure and not options.jsdebugger:
             parser.error(
                 "--debug-on-failure requires --jsdebugger.")
 
         if options.debuggerArgs and not options.debugger:
             parser.error(
                 "--debugger-args requires --debugger.")