Bug 1378397 - Move key-shortcuts.properties to firefox package. r=jdescottes draft
authorAlexandre Poirot <poirot.alex@gmail.com>
Thu, 13 Jul 2017 20:30:26 +0200
changeset 612213 d870190aa8387fa35ea2c124f3fa27cc5caf00f3
parent 612212 7eb9bff77f73552ea4a4afbc76db5847cce54f44
child 612214 c683a1b7e3061fccfecb6fc3c6d39660f4634bbf
push id69438
push userbmo:poirot.alex@gmail.com
push dateThu, 20 Jul 2017 14:18:30 +0000
reviewersjdescottes
bugs1378397
milestone56.0a1
Bug 1378397 - Move key-shortcuts.properties to firefox package. r=jdescottes If we stop packaging DevTools in Firefox, this file would miss from devtools-startup.js. MozReview-Commit-ID: JGYIigvIIRt
browser/locales/en-US/chrome/browser/devtools/key-shortcuts.properties
browser/locales/jar.mn
devtools/client/devtools-startup.js
devtools/client/devtools-startup.manifest
devtools/client/locales/en-US/key-shortcuts.properties
devtools/client/moz.build
devtools/shim/devtools-startup.js
devtools/shim/devtools-startup.manifest
devtools/shim/moz.build
rename from devtools/client/locales/en-US/key-shortcuts.properties
rename to browser/locales/en-US/chrome/browser/devtools/key-shortcuts.properties
--- a/browser/locales/jar.mn
+++ b/browser/locales/jar.mn
@@ -40,16 +40,17 @@
     locale/browser/engineManager.properties        (%chrome/browser/engineManager.properties)
     locale/browser/setDesktopBackground.dtd        (%chrome/browser/setDesktopBackground.dtd)
     locale/browser/shellservice.properties         (%chrome/browser/shellservice.properties)
     locale/browser/tabbrowser.properties           (%chrome/browser/tabbrowser.properties)
     locale/browser/taskbar.properties              (%chrome/browser/taskbar.properties)
     locale/browser/translation.dtd                 (%chrome/browser/translation.dtd)
     locale/browser/translation.properties          (%chrome/browser/translation.properties)
     locale/browser/webrtcIndicator.properties      (%chrome/browser/webrtcIndicator.properties)
+    locale/browser/devtools/key-shortcuts.properties (%chrome/browser/devtools/key-shortcuts.properties)
     locale/browser/downloads/downloads.dtd         (%chrome/browser/downloads/downloads.dtd)
     locale/browser/downloads/downloads.properties  (%chrome/browser/downloads/downloads.properties)
     locale/browser/places/places.dtd               (%chrome/browser/places/places.dtd)
     locale/browser/places/places.properties        (%chrome/browser/places/places.properties)
     locale/browser/places/editBookmarkOverlay.dtd  (%chrome/browser/places/editBookmarkOverlay.dtd)
     locale/browser/places/bookmarkProperties.properties (%chrome/browser/places/bookmarkProperties.properties)
     locale/browser/places/moveBookmarks.dtd        (%chrome/browser/places/moveBookmarks.dtd)
     locale/browser/safebrowsing/phishing-afterload-warning-message.dtd (%chrome/browser/safebrowsing/phishing-afterload-warning-message.dtd)
--- a/devtools/client/moz.build
+++ b/devtools/client/moz.build
@@ -35,21 +35,16 @@ DIRS += [
     'webconsole',
     'webide',
 ]
 
 # Shim old theme paths used by DevTools add-ons
 if CONFIG['MOZ_BUILD_APP'] == 'browser':
     DIRS += ['themes/shims']
 
-EXTRA_COMPONENTS += [
-    'devtools-startup.js',
-    'devtools-startup.manifest',
-]
-
 JAR_MANIFESTS += ['jar.mn']
 
 DevToolsModules(
     'definitions.js',
     'menus.js',
 )
 
 with Files('**'):
rename from devtools/client/devtools-startup.js
rename to devtools/shim/devtools-startup.js
--- a/devtools/client/devtools-startup.js
+++ b/devtools/shim/devtools-startup.js
@@ -31,17 +31,17 @@ XPCOMUtils.defineLazyModuleGetter(this, 
 XPCOMUtils.defineLazyModuleGetter(this, "CustomizableUI",
                                   "resource:///modules/CustomizableUI.jsm");
 XPCOMUtils.defineLazyModuleGetter(this, "CustomizableWidgets",
                                   "resource:///modules/CustomizableWidgets.jsm");
 XPCOMUtils.defineLazyModuleGetter(this, "DevToolsShim",
                                   "chrome://devtools-shim/content/DevToolsShim.jsm");
 
 XPCOMUtils.defineLazyGetter(this, "Bundle", function () {
-  const kUrl = "chrome://devtools/locale/key-shortcuts.properties";
+  const kUrl = "chrome://browser/locale/devtools/key-shortcuts.properties";
   return Services.strings.createBundle(kUrl);
 });
 
 XPCOMUtils.defineLazyGetter(this, "KeyShortcuts", function () {
   const isMac = AppConstants.platform == "macosx";
 
   // Common modifier shared by most key shortcuts
   const modifiers = isMac ? "accel,alt" : "accel,shift";
rename from devtools/client/devtools-startup.manifest
rename to devtools/shim/devtools-startup.manifest
--- a/devtools/shim/moz.build
+++ b/devtools/shim/moz.build
@@ -6,16 +6,18 @@
 
 JAR_MANIFESTS += ['jar.mn']
 
 # Register the about:debugging page only for 'addon' and 'all' builds.
 if CONFIG['MOZ_DEVTOOLS'] != 'server':
     EXTRA_COMPONENTS += [
         'aboutdebugging-registration.js',
         'aboutdebugging.manifest',
+        'devtools-startup.js',
+        'devtools-startup.manifest',
     ]
 
 JS_PREFERENCE_FILES += [
     'preferences.js',
 ]
 
 
 XPCSHELL_TESTS_MANIFESTS += ['tests/unit/xpcshell.ini']