Bug 1304042 - Fail the build if running dsymutil fails. draft
authorChris Manchester <cmanchester@mozilla.com>
Thu, 13 Jul 2017 11:57:50 -0700
changeset 608527 e46cdf5887a0bc041fce75af19ac867047c2d333
parent 607669 03bcd6d65af62c5e60a0ab9247ccce43885e707b
child 637332 21e9b7493204b7fdd1a7c37c0cd88681c152fe0f
push id68308
push userbmo:cmanchester@mozilla.com
push dateThu, 13 Jul 2017 19:52:54 +0000
bugs1304042
milestone56.0a1
Bug 1304042 - Fail the build if running dsymutil fails. MozReview-Commit-ID: 9ROIRpuoVGR
toolkit/crashreporter/tools/symbolstore.py
--- a/toolkit/crashreporter/tools/symbolstore.py
+++ b/toolkit/crashreporter/tools/symbolstore.py
@@ -815,16 +815,17 @@ class Dumper_Mac(Dumper):
         try:
             cmd = ([dsymutil] +
                    [a.replace('-a ', '--arch=') for a in self.archs if a] +
                    [file])
             print(' '.join(cmd), file=sys.stderr)
             subprocess.check_call(cmd, stdout=open(os.devnull, 'w'))
         except subprocess.CalledProcessError as e:
             print('Error running dsymutil: %s' % str(e), file=sys.stderr)
+            raise
 
         if not os.path.exists(dsymbundle):
             # dsymutil won't produce a .dSYM for files without symbols
             print("No symbols found in file: %s" % (file,), file=sys.stderr)
             return False
 
         elapsed = time.time() - t_start
         print('Finished processing %s in %.2fs' % (file, elapsed),