Bug 1379021 - Remove card wrapper from highlight items. r?mcomella draft
authorSebastian Kaspari <s.kaspari@gmail.com>
Thu, 13 Jul 2017 13:23:49 +0200
changeset 615942 2c1c4c69d1f942babd3c97dd42bc564ae742bc13
parent 615779 e8400551c2e39f24c75a009ebed496c7acd7bf47
child 615943 077a9761a0077905b157da6918c34319d68e0f33
push id70532
push users.kaspari@gmail.com
push dateWed, 26 Jul 2017 15:42:23 +0000
reviewersmcomella
bugs1379021
milestone56.0a1
Bug 1379021 - Remove card wrapper from highlight items. r?mcomella MozReview-Commit-ID: 3CYSz6aTxqm
mobile/android/app/src/main/res/layout/activity_stream_card_history_item.xml
--- a/mobile/android/app/src/main/res/layout/activity_stream_card_history_item.xml
+++ b/mobile/android/app/src/main/res/layout/activity_stream_card_history_item.xml
@@ -1,22 +1,17 @@
-<?xml version="1.0" encoding="utf-8"?><!-- This Source Code Form is subject to the terms of the Mozilla Public
+<?xml version="1.0" encoding="utf-8"?>
+<!-- This Source Code Form is subject to the terms of the Mozilla Public
    - License, v. 2.0. If a copy of the MPL was not distributed with this
    - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
-
-<android.support.v7.widget.CardView xmlns:android="http://schemas.android.com/apk/res/android"
+<FrameLayout xmlns:android="http://schemas.android.com/apk/res/android"
     xmlns:gecko="http://schemas.android.com/apk/res-auto"
     xmlns:tools="http://schemas.android.com/tools"
     android:layout_width="match_parent"
     android:layout_height="wrap_content"
-    android:layout_marginBottom="10dp"
-    android:layout_marginEnd="@dimen/activity_stream_base_margin"
-    android:layout_marginLeft="@dimen/activity_stream_base_margin"
-    android:layout_marginRight="@dimen/activity_stream_base_margin"
-    android:layout_marginStart="@dimen/activity_stream_base_margin"
     android:layout_marginTop="0dp"
     android:orientation="vertical">
 
     <RelativeLayout
         android:layout_width="fill_parent"
         android:layout_height="wrap_content"
         android:orientation="horizontal"
         android:background="?android:attr/selectableItemBackground">
@@ -28,27 +23,25 @@
             android:id="@+id/icon_wrapper"
             android:layout_width="wrap_content"
             android:layout_height="wrap_content">
 
             <org.mozilla.gecko.widget.FaviconView
                 android:id="@+id/icon"
                 android:layout_width="@dimen/favicon_bg"
                 android:layout_height="@dimen/favicon_bg"
-                android:layout_marginLeft="@dimen/activity_stream_base_margin"
                 android:layout_marginStart="@dimen/activity_stream_base_margin"
                 android:layout_marginTop="@dimen/activity_stream_base_margin"
                 android:layout_marginBottom="@dimen/activity_stream_base_margin"
                 android:layout_gravity="center"
                 gecko:enableRoundCorners="false"
                 tools:background="@drawable/favicon_globe" />
 
         </FrameLayout>
 
-
         <ImageView
             android:id="@+id/menu"
             android:layout_width="wrap_content"
             android:layout_height="36dp"
             android:layout_margin="2dp"
             android:layout_alignParentEnd="true"
             android:layout_alignParentRight="true"
             android:layout_alignParentTop="true"
@@ -126,9 +119,9 @@
                 android:layout_width="wrap_content"
                 android:layout_height="wrap_content"
                 android:textSize="12sp"
                 android:textColor="@color/activity_stream_timestamp"
                 tools:text="20m" />
 
         </LinearLayout>
     </RelativeLayout>
-</android.support.v7.widget.CardView>
+</FrameLayout>