Bug 1380118 - aom: Filter out CONFIG_EXT_PARTITION_TYPES. r?kinetik,froydnj draft
authorRalph Giles <giles@mozilla.com>
Fri, 11 Aug 2017 14:20:11 -0700
changeset 651852 39bdd3a53f313f45351c1af164fa1f142aae45cb
parent 651851 4bd14d11a4487f234fa5cbe8baa61351d1baf8bb
child 651853 3a56cd81c25af572f8bb293289216b3f922549f2
push id75832
push userbmo:giles@thaumas.net
push dateThu, 24 Aug 2017 03:49:46 +0000
reviewerskinetik, froydnj
bugs1380118
milestone57.0a1
Bug 1380118 - aom: Filter out CONFIG_EXT_PARTITION_TYPES. r?kinetik,froydnj aom_dsp_rtcd_defs.pl checks only whether this key is present in the config, not whether it is set to true or not. Our script sets CONFIG_FOO=no for disabled options, while the upstream build system omits them, resulting in extra symbol declarations the build will never define. Work around this by stripping the offending disabled config key if it is disabled. MozReview-Commit-ID: IyVDO2G3s3L
media/libaom/lint_config.sh
--- a/media/libaom/lint_config.sh
+++ b/media/libaom/lint_config.sh
@@ -99,14 +99,17 @@ fi
 if [ "$print_final" = "no" ]; then
   exit
 fi
 
 # Do some additional filter to make libvpx happy.
 combined_config="$(echo "$combined_config" | grep -v ARCH_X86=no)"
 combined_config="$(echo "$combined_config" | grep -v ARCH_X86_64=no)"
 
+# aom_dsp_rtcd_defs.h checks for definition here, not value.
+combined_config="$(echo "$combined_config" | grep -v CONFIG_EXT_PARTITION_TYPES=no)"
+
 # Print out the unique configurations.
 if [ -n "$out_file" ]; then
   echo "$combined_config" | sort | uniq > $out_file
 else
   echo "$combined_config" | sort | uniq
 fi