Bug 1377989 - part4: Rename nsRange::GetParentAndOffsetBefore() to nsRange::GetContainerAndOffsetBefore() r?mats draft
authorMasayuki Nakano <masayuki@d-toybox.com>
Tue, 11 Jul 2017 21:23:54 +0900
changeset 606927 a67fc37aa3dea5b9537e726af468abba786f5327
parent 606926 8b9d1b3afdde951c145dbb3fdcffccd4b41daafb
child 606928 879d93e467197820f303017a09e7a2fc6c3fec14
push id67831
push usermasayuki@d-toybox.com
push dateTue, 11 Jul 2017 15:21:54 +0000
reviewersmats
bugs1377989
milestone56.0a1
Bug 1377989 - part4: Rename nsRange::GetParentAndOffsetBefore() to nsRange::GetContainerAndOffsetBefore() r?mats MozReview-Commit-ID: 5ihlHifgZMt
dom/base/nsRange.cpp
dom/base/nsRange.h
--- a/dom/base/nsRange.cpp
+++ b/dom/base/nsRange.cpp
@@ -1261,17 +1261,17 @@ nsRange::SetStartBefore(nsINode& aNode, 
   if (!nsContentUtils::LegacyIsCallerNativeCode() &&
       !nsContentUtils::CanCallerAccess(&aNode)) {
     aRv.Throw(NS_ERROR_DOM_SECURITY_ERR);
     return;
   }
 
   AutoInvalidateSelection atEndOfBlock(this);
   int32_t offset = -1;
-  nsINode* parent = GetParentAndOffsetBefore(&aNode, &offset);
+  nsINode* parent = GetContainerAndOffsetBefore(&aNode, &offset);
   aRv = SetStart(parent, offset);
 }
 
 NS_IMETHODIMP
 nsRange::SetStartBefore(nsIDOMNode* aSibling)
 {
   nsCOMPtr<nsINode> sibling = do_QueryInterface(aSibling);
   if (!sibling) {
@@ -1451,17 +1451,17 @@ nsRange::SetEndBefore(nsINode& aNode, Er
   if (!nsContentUtils::LegacyIsCallerNativeCode() &&
       !nsContentUtils::CanCallerAccess(&aNode)) {
     aRv.Throw(NS_ERROR_DOM_SECURITY_ERR);
     return;
   }
 
   AutoInvalidateSelection atEndOfBlock(this);
   int32_t offset = -1;
-  nsINode* parent = GetParentAndOffsetBefore(&aNode, &offset);
+  nsINode* parent = GetContainerAndOffsetBefore(&aNode, &offset);
   aRv = SetEnd(parent, offset);
 }
 
 NS_IMETHODIMP
 nsRange::SetEndBefore(nsIDOMNode* aSibling)
 {
   nsCOMPtr<nsINode> sibling = do_QueryInterface(aSibling);
   if (!sibling) {
--- a/dom/base/nsRange.h
+++ b/dom/base/nsRange.h
@@ -183,17 +183,17 @@ public:
     MOZ_ASSERT(aOffset);
     nsINode* parentNode = aNode->GetParentNode();
     *aOffset = parentNode ? parentNode->IndexOf(aNode) : -1;
     if (*aOffset >= 0) {
       (*aOffset)++;
     }
     return parentNode;
   }
-  static nsINode* GetParentAndOffsetBefore(nsINode* aNode, int32_t* aOffset)
+  static nsINode* GetContainerAndOffsetBefore(nsINode* aNode, int32_t* aOffset)
   {
     MOZ_ASSERT(aNode);
     MOZ_ASSERT(aOffset);
     nsINode* parentNode = aNode->GetParentNode();
     *aOffset = parentNode ? parentNode->IndexOf(aNode) : -1;
     return parentNode;
   }