Bug 1377989 - part3: Rename nsRange::GetParentAndOffsetAfter() to nsRange::GetContainerAndOffsetAfter() r?mats draft
authorMasayuki Nakano <masayuki@d-toybox.com>
Tue, 11 Jul 2017 21:17:52 +0900
changeset 606926 8b9d1b3afdde951c145dbb3fdcffccd4b41daafb
parent 606925 c1557b99d00d066b89fe266c10415e1cf616d1c2
child 606927 a67fc37aa3dea5b9537e726af468abba786f5327
push id67831
push usermasayuki@d-toybox.com
push dateTue, 11 Jul 2017 15:21:54 +0000
reviewersmats
bugs1377989
milestone56.0a1
Bug 1377989 - part3: Rename nsRange::GetParentAndOffsetAfter() to nsRange::GetContainerAndOffsetAfter() r?mats MozReview-Commit-ID: LsRjvVmfJmC
dom/base/nsRange.cpp
dom/base/nsRange.h
extensions/spellcheck/src/mozInlineSpellChecker.cpp
--- a/dom/base/nsRange.cpp
+++ b/dom/base/nsRange.cpp
@@ -1297,17 +1297,17 @@ nsRange::SetStartAfter(nsINode& aNode, E
   if (!nsContentUtils::LegacyIsCallerNativeCode() &&
       !nsContentUtils::CanCallerAccess(&aNode)) {
     aRv.Throw(NS_ERROR_DOM_SECURITY_ERR);
     return;
   }
 
   AutoInvalidateSelection atEndOfBlock(this);
   int32_t offset = -1;
-  nsINode* parent = GetParentAndOffsetAfter(&aNode, &offset);
+  nsINode* parent = GetContainerAndOffsetAfter(&aNode, &offset);
   aRv = SetStart(parent, offset);
 }
 
 NS_IMETHODIMP
 nsRange::SetStartAfter(nsIDOMNode* aSibling)
 {
   nsCOMPtr<nsINode> sibling = do_QueryInterface(aSibling);
   if (!sibling) {
@@ -1487,17 +1487,17 @@ nsRange::SetEndAfter(nsINode& aNode, Err
   if (!nsContentUtils::LegacyIsCallerNativeCode() &&
       !nsContentUtils::CanCallerAccess(&aNode)) {
     aRv.Throw(NS_ERROR_DOM_SECURITY_ERR);
     return;
   }
 
   AutoInvalidateSelection atEndOfBlock(this);
   int32_t offset = -1;
-  nsINode* parent = GetParentAndOffsetAfter(&aNode, &offset);
+  nsINode* parent = GetContainerAndOffsetAfter(&aNode, &offset);
   aRv = SetEnd(parent, offset);
 }
 
 NS_IMETHODIMP
 nsRange::SetEndAfter(nsIDOMNode* aSibling)
 {
   nsCOMPtr<nsINode> sibling = do_QueryInterface(aSibling);
   if (!sibling) {
--- a/dom/base/nsRange.h
+++ b/dom/base/nsRange.h
@@ -172,17 +172,17 @@ public:
   {
     return SetStartAndEnd(aParent, aOffset, aParent, aOffset);
   }
 
   /**
    * Retrieves node and offset for setting start or end of a range to
    * before or after aNode.
    */
-  static nsINode* GetParentAndOffsetAfter(nsINode* aNode, int32_t* aOffset)
+  static nsINode* GetContainerAndOffsetAfter(nsINode* aNode, int32_t* aOffset)
   {
     MOZ_ASSERT(aNode);
     MOZ_ASSERT(aOffset);
     nsINode* parentNode = aNode->GetParentNode();
     *aOffset = parentNode ? parentNode->IndexOf(aNode) : -1;
     if (*aOffset >= 0) {
       (*aOffset)++;
     }
--- a/extensions/spellcheck/src/mozInlineSpellChecker.cpp
+++ b/extensions/spellcheck/src/mozInlineSpellChecker.cpp
@@ -1212,17 +1212,17 @@ mozInlineSpellChecker::MakeSpellCheckRan
   nsCOMPtr<nsINode> endNode = do_QueryInterface(aEndNode);
   if (aEndOffset) {
     rv = range->SetStartAndEnd(startNode, aStartOffset, endNode, aEndOffset);
     if (NS_WARN_IF(NS_FAILED(rv))) {
       return rv;
     }
   } else {
     int32_t endOffset = -1;
-    endNode = nsRange::GetParentAndOffsetAfter(endNode, &endOffset);
+    endNode = nsRange::GetContainerAndOffsetAfter(endNode, &endOffset);
     rv = range->SetStartAndEnd(startNode, aStartOffset, endNode, endOffset);
     if (NS_WARN_IF(NS_FAILED(rv))) {
       return rv;
     }
   }
 
   range.swap(*aRange);
   return NS_OK;