Bug 1379785 - Stop calling abspath on symbol_archive paths. draft
authorTom Prince <mozilla@hocat.ca>
Mon, 10 Jul 2017 15:25:04 -0600
changeset 606342 af9f45afbaf892f0c9d468268c5a03bead8c89b3
parent 606207 d6f2a893cd7a77cacbb1b139fff78d09c2f001e0
child 636752 f11ebbc78155824cca48025f96018779368fba5f
push id67685
push userbmo:mozilla@hocat.ca
push dateMon, 10 Jul 2017 21:59:15 +0000
bugs1379785
milestone56.0a1
Bug 1379785 - Stop calling abspath on symbol_archive paths. Thunderbird is still using MOZ_PKG_PRETTYNAMES which has spaces in the package name, which gets mangled by abspath. MozReview-Commit-ID: 23ngx6gIESI
Makefile.in
--- a/Makefile.in
+++ b/Makefile.in
@@ -265,26 +265,26 @@ prepsymbolsarchive:
 
 ifndef MOZ_AUTOMATION
 prepsymbolsarchive: recurse_syms
 endif
 
 .PHONY: symbolsfullarchive
 symbolsfullarchive: prepsymbolsarchive
 	$(RM) '$(DIST)/$(PKG_PATH)$(SYMBOL_FULL_ARCHIVE_BASENAME).zip'
-	$(call py_action,symbols_archive,$(abspath '$(DIST)/$(PKG_PATH)$(SYMBOL_FULL_ARCHIVE_BASENAME).zip') \
+	$(call py_action,symbols_archive,'$(DIST)/$(PKG_PATH)$(SYMBOL_FULL_ARCHIVE_BASENAME).zip' \
                                      $(abspath $(DIST)/crashreporter-symbols) \
                                      --exclude '*test*' \
                                      --exclude '*Test*' \
                                      --compress '**/*.sym')
 
 .PHONY: symbolsarchive
 symbolsarchive: prepsymbolsarchive
 	$(RM) '$(DIST)/$(PKG_PATH)$(SYMBOL_ARCHIVE_BASENAME).zip'
-	$(call py_action,symbols_archive,$(abspath '$(DIST)/$(PKG_PATH)$(SYMBOL_ARCHIVE_BASENAME).zip') \
+	$(call py_action,symbols_archive,'$(DIST)/$(PKG_PATH)$(SYMBOL_ARCHIVE_BASENAME).zip' \
                                      $(abspath $(DIST)/crashreporter-symbols) \
                                      --include '**/*.sym')
 
 ifdef MOZ_CRASHREPORTER
 buildsymbols: symbolsfullarchive symbolsarchive
 else
 buildsymbols:
 endif