Bug 1379382 - Correct rust srcdir url. r?gps draft
authorRalph Giles <giles@mozilla.com>
Sat, 08 Jul 2017 08:00:27 -0700
changeset 605629 b04a2c37e9aebb21bdcc448e35baa858fd657119
parent 605605 04442951d5c978d95a91b097849d9d8cda335178
child 636558 d5149024498ac6cef54e2802f49f5856e4002926
push id67480
push userbmo:giles@thaumas.net
push dateSat, 08 Jul 2017 15:07:04 +0000
reviewersgps
bugs1379382
milestone56.0a1
Bug 1379382 - Correct rust srcdir url. r?gps We were prefix-matching the rust srcdir when hyperlinking symbols, but then appending the relative source path to the top level repo url, resulting in broken links. Instead, link to the srcdir url at github. MozReview-Commit-ID: 33tSMM96Vie
toolkit/crashreporter/tools/symbolstore.py
--- a/toolkit/crashreporter/tools/symbolstore.py
+++ b/toolkit/crashreporter/tools/symbolstore.py
@@ -402,17 +402,17 @@ class Dumper:
         elif target_os == 'Darwin':
             rust_srcdir = '/Users/travis/build/rust-lang/rust/src/'
         elif target_os == 'Linux':
             rust_srcdir = '/checkout/src/'
         if rust_srcdir is not None:
             self.srcdirs.append(rust_srcdir)
             Dumper.srcdirRepoInfo[rust_srcdir] = GitRepoInfo(rust_srcdir,
                                                              buildconfig.substs['RUSTC_COMMIT'],
-                                                             'https://github.com/rust-lang/rust/')
+                                                             'https://github.com/rust-lang/rust/src/')
 
     def parse_repo_manifest(self, repo_manifest):
         """
         Parse an XML manifest of repository info as produced
         by the `repo manifest -r` command.
         """
         doc = parse(repo_manifest)
         if doc.firstChild.tagName != "manifest":