Bug 1379095 - add nsIRequest in nsAboutCacheEntry::Channel QI. r?mayhemer draft
authorShih-Chiang Chien <schien@mozilla.com>
Fri, 07 Jul 2017 15:32:33 +0800
changeset 605266 b11c1a3a223926283542304aa39ea3bfb4fba6a2
parent 605265 a0b5515b13ebfd3220a06fd1cd31f98a9557f031
child 636434 66b5063066c47ec495fac1b55c455d4401c59ce7
push id67344
push userbmo:schien@mozilla.com
push dateFri, 07 Jul 2017 09:10:11 +0000
reviewersmayhemer
bugs1379095, 1266196
milestone56.0a1
Bug 1379095 - add nsIRequest in nsAboutCacheEntry::Channel QI. r?mayhemer nsAboutCacheEntry::Channel is introduced by Bug 1266196. Assert_NoQueryNeeded() check is failed due to nsAboutCacheEntry::Channel return nullptr while QI into a nsCOMPtr<nsIRequest> pointer. MozReview-Commit-ID: 4lYeN4lNtTm
netwerk/protocol/about/nsAboutCacheEntry.cpp
--- a/netwerk/protocol/about/nsAboutCacheEntry.cpp
+++ b/netwerk/protocol/about/nsAboutCacheEntry.cpp
@@ -82,16 +82,17 @@ HexDump(uint32_t *state, const char *buf
 // nsAboutCacheEntry::nsISupports
 
 NS_IMPL_ISUPPORTS(nsAboutCacheEntry,
                   nsIAboutModule)
 NS_IMPL_ISUPPORTS(nsAboutCacheEntry::Channel,
                   nsICacheEntryOpenCallback,
                   nsICacheEntryMetaDataVisitor,
                   nsIStreamListener,
+                  nsIRequest,
                   nsIChannel)
 
 //-----------------------------------------------------------------------------
 // nsAboutCacheEntry::nsIAboutModule
 
 NS_IMETHODIMP
 nsAboutCacheEntry::NewChannel(nsIURI* uri,
                               nsILoadInfo* aLoadInfo,