Bug 1379066 - 9. Java implementation apply different style draft
authorJulian_Chu <walkingice0204@gmail.com>
Fri, 07 Jul 2017 15:50:14 +0800
changeset 607550 dbfe0d6bc03210ddd8ddba64518ec15f2dd11a8b
parent 607549 b9fc629f906d4afa44ce72a639bae3319e8b1651
child 607551 f070baefdb0f130a9a45c4ae7e53e21d0197baf2
push id68017
push userbmo:walkingice0204@gmail.com
push dateWed, 12 Jul 2017 10:37:39 +0000
bugs1379066
milestone56.0a1
Bug 1379066 - 9. Java implementation apply different style We draw curve for Toolbar only in Australis flavor. Also change resource naming for highlight color to be consistent with Phton flavor. MozReview-Commit-ID: E7cFuJs3r6h
mobile/android/app/src/australis/res/values/colors.xml
mobile/android/base/java/org/mozilla/gecko/CustomEditText.java
mobile/android/base/java/org/mozilla/gecko/toolbar/BrowserToolbarPhoneBase.java
--- a/mobile/android/app/src/australis/res/values/colors.xml
+++ b/mobile/android/app/src/australis/res/values/colors.xml
@@ -95,17 +95,18 @@
   <color name="text_color_link">#22629E</color>
 
   <!-- Divider colors -->
   <color name="toolbar_divider_grey">#D7D9DB</color>
 
   <color name="doorhanger_link">#FF2AA1FE</color>
 
   <color name="validation_message_text">#ffffff</color>
-  <color name="url_bar_text_highlight_pb">#FFD06BFF</color>
+  <color name="url_bar_text_highlight">@color/fennec_ui_orange</color>
+  <color name="url_bar_text_highlight_private">#FFD06BFF</color>
   <color name="tab_row_pressed">#4D000000</color>
 
   <color name="url_bar_urltext">#AFB1B3</color>
   <color name="url_bar_urltext_private">#777777</color>
   <color name="url_bar_domaintext">#363B40</color>
   <color name="url_bar_domaintext_private">#FFFFFF</color>
   <color name="url_bar_blockedtext">#b14646</color>
   <color name="url_bar_blockedtext_private">@color/url_bar_blockedtext</color>
--- a/mobile/android/base/java/org/mozilla/gecko/CustomEditText.java
+++ b/mobile/android/base/java/org/mozilla/gecko/CustomEditText.java
@@ -77,13 +77,14 @@ public class CustomEditText extends Them
         return mHighlightColor;
     }
 
     @Override
     public void setPrivateMode(boolean isPrivate) {
         super.setPrivateMode(isPrivate);
 
         mHighlightColor = ContextCompat.getColor(getContext(), isPrivate
-                ? R.color.url_bar_text_highlight_pb : R.color.fennec_ui_orange);
+                ? R.color.url_bar_text_highlight_private : R.color.url_bar_text_highlight);
+
         // android:textColorHighlight cannot support a ColorStateList.
         setHighlightColor(mHighlightColor);
     }
 }
--- a/mobile/android/base/java/org/mozilla/gecko/toolbar/BrowserToolbarPhoneBase.java
+++ b/mobile/android/base/java/org/mozilla/gecko/toolbar/BrowserToolbarPhoneBase.java
@@ -134,18 +134,21 @@ abstract class BrowserToolbarPhoneBase e
     protected void updateNavigationButtons(final Tab tab) {
         // We have no navigation buttons so do nothing.
     }
 
     @Override
     public void draw(final Canvas canvas) {
         super.draw(canvas);
 
-        if (uiMode == UIMode.DISPLAY) {
-            canvas.drawPath(roundCornerShape, roundCornerPaint);
+        // bug 1375351: Only draw curve in Australis flavor
+        if (SkinConfig.isAustralis()) {
+            if (uiMode == UIMode.DISPLAY) {
+                canvas.drawPath(roundCornerShape, roundCornerPaint);
+            }
         }
     }
 
     @Override
     public void triggerTabsPanelTransition(final PropertyAnimator animator, final boolean areTabsShown) {
         if (areTabsShown) {
             ViewHelper.setAlpha(tabsCounter, 0.0f);