Bug 1378554 - Allow empty titles for synced separators. r=markh draft
authorKit Cambridge <kit@yakshaving.ninja>
Wed, 05 Jul 2017 11:25:02 -0700
changeset 604456 8e5b7db8ac87a18ef15b958011d963bcfe1ed048
parent 604454 718aaa7aa178640e2d28418238c099edf8f4e143
child 636197 7b8dcfd659019da46bbca33b6f3c05ba7923cc09
push id67081
push userbmo:kit@mozilla.com
push dateWed, 05 Jul 2017 23:11:51 +0000
reviewersmarkh
bugs1378554
milestone56.0a1
Bug 1378554 - Allow empty titles for synced separators. r=markh MozReview-Commit-ID: 7dDcIBjhDS4
toolkit/components/places/PlacesSyncUtils.jsm
--- a/toolkit/components/places/PlacesSyncUtils.jsm
+++ b/toolkit/components/places/PlacesSyncUtils.jsm
@@ -1370,17 +1370,18 @@ function validateNewBookmark(info) {
       url: { requiredIf: b => [ BookmarkSyncUtils.KINDS.BOOKMARK,
                                 BookmarkSyncUtils.KINDS.QUERY ].includes(b.kind),
             validIf: b => [ BookmarkSyncUtils.KINDS.BOOKMARK,
                             BookmarkSyncUtils.KINDS.QUERY ].includes(b.kind) },
       parentSyncId: { required: true },
       title: { validIf: b => [ BookmarkSyncUtils.KINDS.BOOKMARK,
                                BookmarkSyncUtils.KINDS.QUERY,
                                BookmarkSyncUtils.KINDS.FOLDER,
-                               BookmarkSyncUtils.KINDS.LIVEMARK ].includes(b.kind) },
+                               BookmarkSyncUtils.KINDS.LIVEMARK ].includes(b.kind) ||
+                             b.title === "" },
       query: { validIf: b => b.kind == BookmarkSyncUtils.KINDS.QUERY },
       folder: { validIf: b => b.kind == BookmarkSyncUtils.KINDS.QUERY },
       tags: { validIf: b => [ BookmarkSyncUtils.KINDS.BOOKMARK,
                               BookmarkSyncUtils.KINDS.QUERY ].includes(b.kind) },
       keyword: { validIf: b => [ BookmarkSyncUtils.KINDS.BOOKMARK,
                                  BookmarkSyncUtils.KINDS.QUERY ].includes(b.kind) },
       description: { validIf: b => [ BookmarkSyncUtils.KINDS.BOOKMARK,
                                      BookmarkSyncUtils.KINDS.QUERY,