Bug 1377920 - Too many WARNING: 'obs' from imagelib in debug builds. r=aosmond draft
authorMarco Bonardo <mbonardo@mozilla.com>
Tue, 04 Jul 2017 14:49:04 +0200
changeset 603739 30add1827cba8508263d0a3c351e104bc5732fa7
parent 603265 283debe8155accfec5812c66e33384ce217d02c2
child 635978 86acb2e0f8db06c7312648838d0c47129fc85786
push id66838
push usermak77@bonardo.net
push dateTue, 04 Jul 2017 12:50:42 +0000
reviewersaosmond
bugs1377920
milestone56.0a1
Bug 1377920 - Too many WARNING: 'obs' from imagelib in debug builds. r=aosmond MozReview-Commit-ID: 5Rt7VUYpOmt
image/ImageFactory.cpp
image/RasterImage.cpp
image/VectorImage.cpp
--- a/image/ImageFactory.cpp
+++ b/image/ImageFactory.cpp
@@ -91,17 +91,18 @@ ImageFactory::CreateImage(nsIRequest* aR
 
   // Compute the image's initialization flags.
   uint32_t imageFlags = ComputeImageFlags(aURI, aMimeType, aIsMultiPart);
 
 #ifdef DEBUG
   // Record the image load for startup performance testing.
   if (NS_IsMainThread()) {
     nsCOMPtr<nsIObserverService> obs = services::GetObserverService();
-    if (NS_WARN_IF(obs)) {
+    NS_WARNING_ASSERTION(obs, "Can't get an observer service handle");
+    if (obs) {
       nsAutoCString spec;
       aURI->GetSpec(spec);
       obs->NotifyObservers(nullptr, "image-loading", NS_ConvertUTF8toUTF16(spec).get());
     }
   }
 #endif
 
   // Select the type of image to create based on MIME type.
--- a/image/RasterImage.cpp
+++ b/image/RasterImage.cpp
@@ -1394,17 +1394,18 @@ RasterImage::DrawInternal(DrawableSurfac
   gfxContextMatrixAutoSaveRestore saveMatrix(aContext);
   ImageRegion region(aRegion);
   bool frameIsFinished = aSurface->IsFinished();
 
 #ifdef DEBUG
   // Record the image drawing for startup performance testing.
   if (NS_IsMainThread()) {
     nsCOMPtr<nsIObserverService> obs = services::GetObserverService();
-    if (NS_WARN_IF(obs)) {
+    NS_WARNING_ASSERTION(obs, "Can't get an observer service handle");
+    if (obs) {
       nsCOMPtr<nsIURI> imageURI = mURI->ToIURI();
       nsAutoCString spec;
       imageURI->GetSpec(spec);
       obs->NotifyObservers(nullptr, "image-drawing", NS_ConvertUTF8toUTF16(spec).get());
     }
   }
 #endif
 
--- a/image/VectorImage.cpp
+++ b/image/VectorImage.cpp
@@ -1024,17 +1024,18 @@ VectorImage::Show(gfxDrawable* aDrawable
                              SurfaceFormat::B8G8R8A8,
                              aParams.samplingFilter,
                              aParams.flags, aParams.opacity);
 
 #ifdef DEBUG
   // Record the image drawing for startup performance testing.
   if (NS_IsMainThread()) {
     nsCOMPtr<nsIObserverService> obs = services::GetObserverService();
-    if (NS_WARN_IF(obs)) {
+    NS_WARNING_ASSERTION(obs, "Can't get an observer service handle");
+    if (obs) {
       nsCOMPtr<nsIURI> imageURI = mURI->ToIURI();
       nsAutoCString spec;
       imageURI->GetSpec(spec);
       obs->NotifyObservers(nullptr, "image-drawing", NS_ConvertUTF8toUTF16(spec).get());
     }
   }
 #endif