Bug 1312623 - Don't attempt to shutdown a thread in the dtor of a GraphDriver, since it might be called by CC. r?smaug draft
authorPaul Adenot <paul@paul.cx>
Tue, 04 Jul 2017 09:21:23 +0200
changeset 603528 ddd094968f60af12e5250304a7636e1e8aa24220
parent 602297 d9a144b7b6d994fc9a497c53b13f51a2a654d85e
child 635955 c3004785ebfeeb1054412709353b6ebbc25f2121
push id66813
push userpaul@paul.cx
push dateTue, 04 Jul 2017 07:24:56 +0000
reviewerssmaug
bugs1312623
milestone56.0a1
Bug 1312623 - Don't attempt to shutdown a thread in the dtor of a GraphDriver, since it might be called by CC. r?smaug MozReview-Commit-ID: HA67HQQrfow
dom/media/GraphDriver.cpp
--- a/dom/media/GraphDriver.cpp
+++ b/dom/media/GraphDriver.cpp
@@ -158,23 +158,19 @@ public:
   }
 private:
   nsCOMPtr<nsIThread> mThread;
 };
 
 ThreadedDriver::~ThreadedDriver()
 {
   if (mThread) {
-    if (NS_IsMainThread()) {
-      mThread->Shutdown();
-    } else {
-      nsCOMPtr<nsIRunnable> event =
-        new MediaStreamGraphShutdownThreadRunnable(mThread.forget());
-      NS_DispatchToMainThread(event);
-    }
+    nsCOMPtr<nsIRunnable> event =
+      new MediaStreamGraphShutdownThreadRunnable(mThread.forget());
+    NS_DispatchToMainThread(event);
   }
 }
 class MediaStreamGraphInitThreadRunnable : public Runnable {
 public:
   explicit MediaStreamGraphInitThreadRunnable(ThreadedDriver* aDriver)
     : Runnable("MediaStreamGraphInitThreadRunnable")
     , mDriver(aDriver)
   {