Bug 1376100 - icons in hamburger panels have too much end-margin causing misalignment, r?dao draft
authorGijs Kruitbosch <gijskruitbosch@gmail.com>
Thu, 29 Jun 2017 18:09:46 +0100
changeset 602096 90bd4b09742fd3f22ef23d94811a09f098645d2c
parent 602051 f3483af8ecf997453064201c49c48a682c7f3c29
child 635458 b46fba42b6bf3e96591e32b06cdf6837b8573596
push id66274
push userbmo:gijskruitbosch+bugs@gmail.com
push dateThu, 29 Jun 2017 17:10:15 +0000
reviewersdao
bugs1376100, 969584
milestone56.0a1
Bug 1376100 - icons in hamburger panels have too much end-margin causing misalignment, r?dao This rule was added in bug 969584 - it's not clear why it had !important. I did both a visual audit of non-photon cases and a code search for lines containing both 'margin' and '!important' in files with 'linux' in their path, and came up with nothing to explain this, so I just removed it. MozReview-Commit-ID: JL96JMp0V90
browser/themes/linux/customizableui/panelUI.css
--- a/browser/themes/linux/customizableui/panelUI.css
+++ b/browser/themes/linux/customizableui/panelUI.css
@@ -77,17 +77,17 @@ menu[disabled="true"].subviewbutton > .m
   -moz-image-region: rect(0, 32px, 16px, 16px);
 }
 
 menu.subviewbutton > .menu-right:-moz-locale-dir(rtl) {
   transform: scaleX(-1);
 }
 
 .subviewbutton > .toolbarbutton-icon {
-  margin-inline-end: 5px !important;
+  margin-inline-end: 5px;
 }
 
 .subviewbutton > .menu-right,
 .subviewbutton > .menu-iconic-left {
   padding-top: 1px;
   /* These need !important to override menu.css */
   margin-top: 1px !important;
   margin-bottom: 2px !important;