Bug 1375931 - Align event name format r=me
MozReview-Commit-ID: 2Af1z7dYnsC
--- a/mobile/android/base/java/org/mozilla/gecko/GeckoApp.java
+++ b/mobile/android/base/java/org/mozilla/gecko/GeckoApp.java
@@ -107,28 +107,26 @@ import java.io.File;
import java.io.IOException;
import java.io.InputStream;
import java.lang.ref.WeakReference;
import java.net.URL;
import java.util.ArrayList;
import java.util.HashMap;
import java.util.HashSet;
import java.util.Iterator;
-import java.util.LinkedList;
-import java.util.List;
import java.util.Locale;
import java.util.Map;
import java.util.Set;
import java.util.concurrent.TimeUnit;
import static org.mozilla.gecko.Tabs.INTENT_EXTRA_SESSION_UUID;
import static org.mozilla.gecko.Tabs.INTENT_EXTRA_TAB_ID;
import static org.mozilla.gecko.Tabs.INVALID_TAB_ID;
-import static org.mozilla.gecko.mma.MmaDelegate.DOWNLOAD_VIDEOS_OR_ANY_OTHER_MEDIA;
-import static org.mozilla.gecko.mma.MmaDelegate.LOADS_ARTICLES;
+import static org.mozilla.gecko.mma.MmaDelegate.DOWNLOAD_MEDIA_SAVED_IMAGE;
+import static org.mozilla.gecko.mma.MmaDelegate.READER_AVAILABLE;
public abstract class GeckoApp extends GeckoActivity
implements AnchoredPopup.OnVisibilityChangeListener,
BundleEventListener,
GeckoMenu.Callback,
GeckoMenu.MenuPresenter,
GeckoView.ContentListener,
ScreenOrientationDelegate,
@@ -863,20 +861,20 @@ public abstract class GeckoApp extends G
UpdateServiceHelper.applyUpdate(this);
} else if ("PluginHelper:playFlash".equals(event)) {
final SharedPreferences prefs = getSharedPreferences();
int count = prefs.getInt(PREFS_FLASH_USAGE, 0);
prefs.edit().putInt(PREFS_FLASH_USAGE, ++count).apply();
} else if ("Mma:reader_available".equals(event)) {
- MmaDelegate.track(LOADS_ARTICLES);
+ MmaDelegate.track(READER_AVAILABLE);
} else if ("Mma:web_save_media".equals(event) || "Mma:web_save_image".equals(event)) {
- MmaDelegate.track(DOWNLOAD_VIDEOS_OR_ANY_OTHER_MEDIA);
+ MmaDelegate.track(DOWNLOAD_MEDIA_SAVED_IMAGE);
}
}
/**
* To get a presenter which will response for text-selection. In preMarshmallow Android we want
* to provide different UI action when user select a text. Text-selection class will uses this
--- a/mobile/android/base/java/org/mozilla/gecko/Tabs.java
+++ b/mobile/android/base/java/org/mozilla/gecko/Tabs.java
@@ -47,17 +47,17 @@ import android.os.Handler;
import android.os.SystemClock;
import android.provider.Browser;
import android.support.annotation.UiThread;
import android.support.v4.content.ContextCompat;
import android.text.TextUtils;
import android.util.Log;
import static org.mozilla.gecko.Tab.TabType;
-import static org.mozilla.gecko.mma.MmaDelegate.VISITING_A_WEBSITE_WITH_MATCH_TO_PAST_HISTORY;
+import static org.mozilla.gecko.mma.MmaDelegate.REVISIT_WEBSITE;
public class Tabs implements BundleEventListener {
private static final String LOGTAG = "GeckoTabs";
public static final String INTENT_EXTRA_TAB_ID = "TabId";
public static final String INTENT_EXTRA_SESSION_UUID = "SessionUUID";
private static final String PRIVATE_TAB_INTENT_EXTRA = "private_tab";
@@ -1105,17 +1105,17 @@ public class Tabs implements BundleEvent
return tabToSelect;
}
private void tracking(String url) {
AddToHomeScreenPromotion.URLHistory history = AddToHomeScreenPromotion.getHistoryForURL(mAppContext, url);
if (history != null && history.visits > 0) {
- MmaDelegate.track(VISITING_A_WEBSITE_WITH_MATCH_TO_PAST_HISTORY, history.visits);
+ MmaDelegate.track(REVISIT_WEBSITE, history.visits);
}
}
/**
* Opens a new tab and loads either about:home or, if PREFS_HOMEPAGE_FOR_EVERY_NEW_TAB is set,
* the user's homepage.
*/
public Tab addTab() {
--- a/mobile/android/base/java/org/mozilla/gecko/Telemetry.java
+++ b/mobile/android/base/java/org/mozilla/gecko/Telemetry.java
@@ -12,20 +12,20 @@ import org.mozilla.gecko.TelemetryContra
import org.mozilla.gecko.TelemetryContract.Reason;
import org.mozilla.gecko.TelemetryContract.Session;
import org.mozilla.gecko.mma.MmaDelegate;
import android.os.SystemClock;
import android.util.Log;
import static org.mozilla.gecko.mma.MmaDelegate.INTERACT_WITH_SEARCH_URL_AREA;
-import static org.mozilla.gecko.mma.MmaDelegate.LOAD_BOOKMARK;
-import static org.mozilla.gecko.mma.MmaDelegate.SAVE_BOOKMARK;
-import static org.mozilla.gecko.mma.MmaDelegate.SAVE_PASSWORD;
-import static org.mozilla.gecko.mma.MmaDelegate.WHEN_USER_TAKE_A_SCREENSHOT;
+import static org.mozilla.gecko.mma.MmaDelegate.OPENED_BOOKMARK;
+import static org.mozilla.gecko.mma.MmaDelegate.SAVED_BOOKMARK;
+import static org.mozilla.gecko.mma.MmaDelegate.SAVED_LOGIN_AND_PASSWORD;
+import static org.mozilla.gecko.mma.MmaDelegate.SCREENSHOT;
/**
* All telemetry times are relative to one of two clocks:
*
* * Real time since the device was booted, including deep sleep. Use this
* as a substitute for wall clock.
* * Uptime since the device was booted, excluding deep sleep. Use this to
@@ -219,25 +219,25 @@ public class Telemetry {
mappingMmaTracking(eventName, method, extras);
}
private static void mappingMmaTracking(String eventName, Method method, String extras) {
if (eventName == null || method == null || extras == null) {
return;
}
if (eventName.equalsIgnoreCase(Event.SAVE.toString()) && method == Method.MENU && extras.equals("bookmark")) {
- MmaDelegate.track(SAVE_BOOKMARK);
+ MmaDelegate.track(SAVED_BOOKMARK);
} else if (eventName.equalsIgnoreCase(Event.LOAD_URL.toString()) && method == Method.LIST_ITEM && extras.equals("bookmarks")) {
- MmaDelegate.track(LOAD_BOOKMARK);
+ MmaDelegate.track(OPENED_BOOKMARK);
} else if (eventName.equalsIgnoreCase(Event.SHOW.toString()) && method == Method.ACTIONBAR && extras.equals("urlbar-url")) {
MmaDelegate.track(INTERACT_WITH_SEARCH_URL_AREA);
} else if (eventName.equalsIgnoreCase(Event.SHARE.toString()) && method == Method.BUTTON && extras.equals("screenshot")) {
- MmaDelegate.track(WHEN_USER_TAKE_A_SCREENSHOT);
+ MmaDelegate.track(SCREENSHOT);
} else if (eventName.equalsIgnoreCase(Event.ACTION.toString()) && method == Method.DOORHANGER && extras.equals("login-positive")) {
- MmaDelegate.track(SAVE_PASSWORD);
+ MmaDelegate.track(SAVED_LOGIN_AND_PASSWORD);
}
}
public static void sendUIEvent(final Event event, final Method method, final long timestamp,
final String extras) {
sendUIEvent(event.toString(), method, timestamp, extras);
}
--- a/mobile/android/base/java/org/mozilla/gecko/mma/MmaDelegate.java
+++ b/mobile/android/base/java/org/mozilla/gecko/mma/MmaDelegate.java
@@ -21,26 +21,26 @@ import org.mozilla.gecko.PrefsHelper;
import org.mozilla.gecko.preferences.GeckoPreferences;
import org.mozilla.gecko.switchboard.SwitchBoard;
import java.lang.ref.WeakReference;
public class MmaDelegate {
- public static final String LOADS_ARTICLES = "Loads articles";
- public static final String DOWNLOAD_VIDEOS_OR_ANY_OTHER_MEDIA = "Download videos or any other media";
- public static final String CLEAR_PRIVATE_DATA = "Clear Private Data";
- public static final String SAVE_BOOKMARK = "SaveBookmark";
- public static final String LOAD_BOOKMARK = "LoadBookmark";
- public static final String INTERACT_WITH_SEARCH_URL_AREA = "Interact with search url area";
- public static final String WHEN_USER_TAKE_A_SCREENSHOT = "When user take a screenshot";
- public static final String SAVE_PASSWORD = "SavePassword";
- public static final String VISITING_A_WEBSITE_WITH_MATCH_TO_PAST_HISTORY = "Visiting a website with match to past history";
- public static final String LAUNCH_BUT_NOT_DEFAULT_BROWSER = "Launch but not default browser";
+ public static final String READER_AVAILABLE = "E_Reader_Available";
+ public static final String DOWNLOAD_MEDIA_SAVED_IMAGE = "E_Download_Media_Saved_Image";
+ public static final String CLEARED_PRIVATE_DATA = "E_Cleared_Private_Data";
+ public static final String SAVED_BOOKMARK = "E_Saved_Bookmark";
+ public static final String OPENED_BOOKMARK = "E_Opened_Bookmark";
+ public static final String INTERACT_WITH_SEARCH_URL_AREA = "E_Interact_With_Search_URL_Area";
+ public static final String SCREENSHOT = "E_Screenshot";
+ public static final String SAVED_LOGIN_AND_PASSWORD = "E_Saved_Login_And_Password";
+ public static final String REVISIT_WEBSITE = "E_Revisit_Website";
+ public static final String LAUNCH_BUT_NOT_DEFAULT_BROWSER = "E_Launch_But_Not_Default_Browser";
private static final String TAG = "MmaDelegate";
private static final String KEY_PREF_BOOLEAN_MMA_ENABLED = "mma.enabled";
private static final String[] PREFS = { KEY_PREF_BOOLEAN_MMA_ENABLED };
private static boolean isGeckoPrefOn = false;
--- a/mobile/android/base/java/org/mozilla/gecko/preferences/PrivateDataPreference.java
+++ b/mobile/android/base/java/org/mozilla/gecko/preferences/PrivateDataPreference.java
@@ -8,25 +8,22 @@ package org.mozilla.gecko.preferences;
import org.mozilla.gecko.EventDispatcher;
import org.mozilla.gecko.Telemetry;
import org.mozilla.gecko.TelemetryContract;
import org.mozilla.gecko.mma.MmaDelegate;
import org.mozilla.gecko.util.GeckoBundle;
import org.mozilla.gecko.icons.storage.DiskStorage;
-import java.util.Arrays;
-import java.util.Collections;
import java.util.Set;
import android.content.Context;
import android.util.AttributeSet;
-import android.util.Log;
-import static org.mozilla.gecko.mma.MmaDelegate.CLEAR_PRIVATE_DATA;
+import static org.mozilla.gecko.mma.MmaDelegate.CLEARED_PRIVATE_DATA;
class PrivateDataPreference extends MultiPrefMultiChoicePreference {
private static final String LOGTAG = "GeckoPrivateDataPreference";
private static final String PREF_KEY_PREFIX = "private.data.";
public PrivateDataPreference(Context context, AttributeSet attrs) {
super(context, attrs);
@@ -57,11 +54,11 @@ class PrivateDataPreference extends Mult
if (values.contains("private.data.offlineApps")) {
// Remove all icons from storage if removing "Offline website data" was selected.
DiskStorage.get(getContext()).evictAll();
}
// clear private data in gecko
EventDispatcher.getInstance().dispatch("Sanitize:ClearData", data);
- MmaDelegate.track(CLEAR_PRIVATE_DATA);
+ MmaDelegate.track(CLEARED_PRIVATE_DATA);
}
}