Bug 1376128 - Fix undefined id variable; r?automatedtester draft
authorAndreas Tolfsen <ato@sny.no>
Wed, 28 Jun 2017 11:15:00 -0700
changeset 602393 e7a4ca3eacdcb62c1d42007d03224fc1e525c3f2
parent 602392 8414bf9518cfb97300419f7b5d0d29fa43bdda4d
child 602394 196043413dcfeb1edcbb4faedde4cd376a4c8eda
push id66419
push userbmo:ato@sny.no
push dateThu, 29 Jun 2017 23:42:10 +0000
reviewersautomatedtester
bugs1376128
milestone56.0a1
Bug 1376128 - Fix undefined id variable; r?automatedtester We try to delete the element entry by "id", which is not defined. MozReview-Commit-ID: DXAOJAV1z9Q
testing/marionette/element.js
--- a/testing/marionette/element.js
+++ b/testing/marionette/element.js
@@ -168,17 +168,17 @@ element.Store = class {
     if (!el) {
       throw new JavaScriptError(`Element reference not seen before: ${uuid}`);
     }
 
     try {
       el = el.get();
     } catch (e) {
       el = null;
-      delete this.els[id];
+      delete this.els[uuid];
     }
 
     // use XPCNativeWrapper to compare elements (see bug 834266)
     let wrappedFrame = new XPCNativeWrapper(container.frame);
     let wrappedShadowRoot;
     if (container.shadowRoot) {
       wrappedShadowRoot = new XPCNativeWrapper(container.shadowRoot);
     }