Bug 1361855 - Add helper function BrowserUsageTelemetry:_recordTabCount(); r?Gijs draft
authorLie Ryan <lie.1296@gmail.com>
Sun, 11 Jun 2017 19:27:02 +0000
changeset 647632 a0be7ab05a55945bf8dd073a87e603f9d0327610
parent 647631 9f39de2c06ef1ed0efd11f0f974f9cd1fa63098d
child 647633 70f9e6205b028f9e3f1797bc5a2cf8d9d0fc61ad
push id74488
push userbmo:lie.1296@gmail.com
push dateWed, 16 Aug 2017 17:50:44 +0000
reviewersGijs
bugs1361855
milestone57.0a1
Bug 1361855 - Add helper function BrowserUsageTelemetry:_recordTabCount(); r?Gijs MozReview-Commit-ID: B6IRJ904bCr
browser/modules/BrowserUsageTelemetry.jsm
--- a/browser/modules/BrowserUsageTelemetry.jsm
+++ b/browser/modules/BrowserUsageTelemetry.jsm
@@ -93,16 +93,20 @@ function getOpenTabsAndWinsCounts() {
     let win = browserEnum.getNext();
     winCount++;
     tabCount += win.gBrowser.tabs.length;
   }
 
   return { tabCount, winCount };
 }
 
+function getTabCount() {
+  return getOpenTabsAndWinsCounts().tabCount;
+}
+
 function getSearchEngineId(engine) {
   if (engine) {
     if (engine.identifier) {
       return engine.identifier;
     }
     // Due to bug 1222070, we can't directly check Services.telemetry.canRecordExtended
     // here.
     const extendedTelemetry = Services.prefs.getBoolPref("toolkit.telemetry.enabled");
@@ -630,9 +634,13 @@ let BrowserUsageTelemetry = {
       Services.telemetry.scalarSetMaximum(MAX_WINDOW_COUNT_SCALAR_NAME, counts.winCount);
 
       // We won't receive the "TabOpen" event for the first tab within a new window.
       // Account for that.
       this._onTabOpen(counts.tabCount);
     };
     win.addEventListener("load", onLoad);
   },
+
+  _recordTabCount(tabCount = getTabCount()) {
+    Services.telemetry.getHistogramById("TAB_COUNT").add(tabCount);
+  },
 };