Bug 1375615 - Don't render the grid areas overlay for implicit named grid areas. r=pbro draft
authorGabriel Luong <gabriel.luong@gmail.com>
Sat, 24 Jun 2017 13:24:18 -0700
changeset 600235 58a4e4531988195129fb3ee4737084650d53618a
parent 600234 34ee108b7488f55e50b3745641b0f53a40f8247d
child 634934 f8efad9030384ba34194e0e9b6ff4f0afc4e89ee
push id65693
push userbmo:gl@mozilla.com
push dateSat, 24 Jun 2017 20:24:46 +0000
reviewerspbro
bugs1375615
milestone56.0a1
Bug 1375615 - Don't render the grid areas overlay for implicit named grid areas. r=pbro MozReview-Commit-ID: 6mli4vol71G
devtools/server/actors/highlighters/css-grid.js
--- a/devtools/server/actors/highlighters/css-grid.js
+++ b/devtools/server/actors/highlighters/css-grid.js
@@ -1156,17 +1156,21 @@ CssGridHighlighter.prototype = extend(Au
    */
   renderGridAreaOverlay() {
     let padding = 1;
 
     for (let i = 0; i < this.gridData.length; i++) {
       let fragment = this.gridData[i];
 
       for (let area of fragment.areas) {
-        let { rowStart, rowEnd, columnStart, columnEnd } = area;
+        let { rowStart, rowEnd, columnStart, columnEnd, type } = area;
+
+        if (type === "implicit") {
+          continue;
+        }
 
         // Draw the line edges for the grid area
         const areaColStart = fragment.cols.lines[columnStart - 1];
         const areaColEnd = fragment.cols.lines[columnEnd - 1];
 
         const areaRowStart = fragment.rows.lines[rowStart - 1];
         const areaRowEnd = fragment.rows.lines[rowEnd - 1];