Bug 1376024 - Whitelist more known Safe Browsing providers for telemetry purposes. r?dimi draft
authorFrancois Marier <francois@mozilla.com>
Fri, 23 Jun 2017 17:00:45 -0700
changeset 600030 b73a17b10f721739bdf450930ee799dd89c2469c
parent 599983 92dc60b522d81862e52bff5cdb1b698eb5608658
child 634908 56186907830173c00b9e094f9d6462ac96e02dd5
push id65665
push userfmarier@mozilla.com
push dateSat, 24 Jun 2017 00:15:46 +0000
reviewersdimi
bugs1376024
milestone56.0a1
Bug 1376024 - Whitelist more known Safe Browsing providers for telemetry purposes. r?dimi MozReview-Commit-ID: 6Dd1eDSJlzT
toolkit/components/url-classifier/nsUrlClassifierUtils.cpp
--- a/toolkit/components/url-classifier/nsUrlClassifierUtils.cpp
+++ b/toolkit/components/url-classifier/nsUrlClassifierUtils.cpp
@@ -287,21 +287,24 @@ nsUrlClassifierUtils::GetProvider(const 
   return NS_OK;
 }
 
 NS_IMETHODIMP
 nsUrlClassifierUtils::GetTelemetryProvider(const nsACString& aTableName,
                                   nsACString& aProvider)
 {
   GetProvider(aTableName, aProvider);
-  // Filter out build-in providers: mozilla, google, google4
-  // Empty provider is filtered as "other"
+  // Whitelist known providers to avoid reporting on private ones.
+  // An empty provider is treated as "other"
   if (!NS_LITERAL_CSTRING("mozilla").Equals(aProvider) &&
       !NS_LITERAL_CSTRING("google").Equals(aProvider) &&
       !NS_LITERAL_CSTRING("google4").Equals(aProvider) &&
+      !NS_LITERAL_CSTRING("baidu").Equals(aProvider) &&
+      !NS_LITERAL_CSTRING("mozcn").Equals(aProvider) &&
+      !NS_LITERAL_CSTRING("yandex").Equals(aProvider) &&
       !NS_LITERAL_CSTRING(TESTING_TABLE_PROVIDER_NAME).Equals(aProvider)) {
     aProvider.Assign(NS_LITERAL_CSTRING("other"));
   }
 
   return NS_OK;
 }
 
 NS_IMETHODIMP