Bug 1375843 - Temporarily silence warning being generated incorrectly. r?gbrown draft
authorKartikaya Gupta <kgupta@mozilla.com>
Fri, 23 Jun 2017 11:04:34 -0400
changeset 599761 7030471934e384053487a0dd17b2eec1ed2b332c
parent 599733 594cc32b632396a867ef1f98428968b224d82151
child 634841 496bf336aa94e5990913e25b15a0fdf9a7b489fa
push id65593
push userkgupta@mozilla.com
push dateFri, 23 Jun 2017 15:05:02 +0000
reviewersgbrown
bugs1375843
milestone56.0a1
Bug 1375843 - Temporarily silence warning being generated incorrectly. r?gbrown This warning seems to sometimes get generated incorrectly beacuse of a bug in webrender internally. For now we remove the warning to prevent it from flooding job logs and causing timeouts in automation. MozReview-Commit-ID: 2zwGtzINv8t
gfx/webrender/src/clip_scroll_node.rs
--- a/gfx/webrender/src/clip_scroll_node.rs
+++ b/gfx/webrender/src/clip_scroll_node.rs
@@ -187,18 +187,17 @@ impl ClipScrollNode {
     }
 
     pub fn add_child(&mut self, child: ClipId) {
         self.children.push(child);
     }
 
     pub fn finalize(&mut self, new_scrolling: &ScrollingState) {
         match self.node_type {
-            NodeType::ReferenceFrame(_) | NodeType::Clip(_) =>
-                warn!("Tried to scroll a non-scroll node."),
+            NodeType::ReferenceFrame(_) | NodeType::Clip(_) => (),
             NodeType::ScrollFrame(ref mut scrolling) => *scrolling = *new_scrolling,
         }
     }
 
     pub fn set_scroll_origin(&mut self, origin: &LayerPoint, clamp: ScrollClamping) -> bool {
         let scrollable_height = self.scrollable_height();
         let scrollable_width = self.scrollable_width();