Bug 1375231 - Properly compare value for --enable-webrender; r?glandium
"value" here is a PositiveOptionValue, which behaves like a tuple.
Its __eq__ fails if the types of the operands aren't the same. A
string literal isn't a PositiveOptionValue, so the "value == 'build'"
check always fails. This meant that --enable-webrender=build was
always being interpreted as --enable-webrender. Yikes.
MozReview-Commit-ID: 57hWl0VqDmD
--- a/toolkit/moz.configure
+++ b/toolkit/moz.configure
@@ -822,17 +822,17 @@ option('--enable-webrender', nargs='?',
@depends('--enable-webrender', milestone)
def webrender(value, milestone):
build_webrender = None
enable_webrender = None
if value.origin == 'default':
# if nothing is specified, default to just building on Nightly
build_webrender = milestone.is_nightly
- elif value == 'build':
+ elif len(value) and value[0] == 'build':
# if explicitly set to 'build', then we build but don't enable
build_webrender = True
elif bool(value):
# if set to true, then build and enable
build_webrender = True
enable_webrender = True
# in all other cases, don't build it or enable it (defaults are fine)